refactor(project): Remove unused ProjectBuildCache.create factory - #1552
Merged
RandomByte merged 1 commit intoAug 28, 2026
Merged
Conversation
ProjectBuildContext.create() constructs the cache with `new ProjectBuildCache(...)` directly (ProjectBuildContext.js:85). After the async initialization moved out into initSourceIndex(), the static create() factory was reduced to `return new ProjectBuildCache(...)` and its only remaining callers were the unit tests. Remove the factory and have the tests construct via the constructor. Update the constructor and initSourceIndex doc comments that still referenced create().
RandomByte
deleted the
refactor/remove-projectbuildcache-create-factory
branch
August 28, 2026 07:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a leftover from an earlier refactoring.
ProjectBuildContext.create()constructs the cache withnew ProjectBuildCache(...)directly (ProjectBuildContext.js:85). After the async initialization moved out intoinitSourceIndex(), the staticcreate()factory was reduced toreturn new ProjectBuildCache(...)and its only remaining callers were the unit tests.create().