Skip to content

fix(tutorials): resolve rendering and consistency issues across tutorials - #327

Merged
petermuessig merged 1 commit into
mainfrom
fix/tutorial-rendering-consistency
Aug 12, 2026
Merged

fix(tutorials): resolve rendering and consistency issues across tutorials#327
petermuessig merged 1 commit into
mainfrom
fix/tutorial-rendering-consistency

Conversation

@petermuessig

@petermuessig petermuessig commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes four rendering/consistency issues found while reviewing the published tutorials (GitHub Pages + github.com).

1. Root tutorial images 404 on GitHub Pages

The build script (tools/builder/prepare-gh-pages.js) copied root assets/ and per-step steps/*/assets/** into dist/, but never a tutorial's top-level assets/ folder. So dist/<tutorial>/index.md referenced assets/…png that was never published. Added a copy block (mirroring the existing root-assets logic, guarded by existsSync).

Affected: navigation ("Page flow of the final app") and databinding (root preview image) — the two tutorials with a top-level assets/.

2. Backticked file-path headings rendered as gray code spans

navigation, odatav4, and databinding wrapped file-path headings in backticks (e.g. ## `webapp/Component.ts/.js`), which renders as a monospace/gray code span. Removed the backticks from all file-path headings, and shifted the heading hierarchy down one level so these tutorials now match the walkthrough/quickstart outline (## Step N### Preview/### Coding → file headings). The transform is fence-aware, so #-prefixed comment lines inside i18n.properties code blocks are untouched. The .ts/.js dual-extension token and (New)/(Changed) suffixes are preserved.

3. Walkthrough still used screenshots for project structure

Steps 09, 26, 27, 28 showed the folder structure as PNG screenshots. Replaced them with fenced ASCII folder trees (matching the other tutorials), derived from each step's actual webapp/ contents. Unused PNGs are removed.

4. Quickstart heading missing .ts/.js

Steps 02 and 03 had ### webapp/App.controller.js (JS-only) though the code blocks below provide both. Changed to ### webapp/App.controller.ts/.js.

Verification

  • Simulated the asset-copy logic: copies exactly the navigation + databinding root images, skips tutorials without a top-level assets/.
  • grep confirms no backticked path headings remain and no folder-structure screenshots remain in walkthrough.
  • Heading diffs are 1:1 line swaps (no content lost).

Note

The full builder (node tools/builder, which runs ui5 build per step) was not run locally. Worth a CI/preview check before merge.

@petermuessig
petermuessig requested a review from margopolo August 11, 2026 18:59
@petermuessig
petermuessig force-pushed the fix/tutorial-rendering-consistency branch from bed3e60 to 0e3b8c4 Compare August 12, 2026 04:59
…ials

- build: copy each tutorial's top-level assets/ folder into dist/<tutorial>/assets/
  so root README images (navigation, databinding) no longer 404 on GitHub Pages
- navigation/odatav4/databinding: remove backticks from file-path headings that
  rendered as gray code spans, and shift the heading hierarchy down one level to
  match the walkthrough/quickstart outline (fence-aware; i18n code comments untouched)
- walkthrough: replace project-structure screenshots in steps 09/26/27/28 with
  fenced ASCII folder trees, and delete the now-unused screenshot PNGs
- quickstart: fix steps 02/03 headings to use the .ts/.js dual notation
@petermuessig
petermuessig force-pushed the fix/tutorial-rendering-consistency branch from 0e3b8c4 to c170987 Compare August 12, 2026 05:12

@margopolo margopolo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermuessig
petermuessig merged commit f56c2aa into main Aug 12, 2026
3 checks passed
@petermuessig
petermuessig deleted the fix/tutorial-rendering-consistency branch August 12, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants