-
Notifications
You must be signed in to change notification settings - Fork 279
feat(ui5-shellbar) support self-collapsible search #11296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+345
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- packages/fiori/src/themes/ShellBar.css: Language not supported
- packages/fiori/test/pages/ShellBar_evolution.html: Language not supported
Comments suppressed due to low confidence (2)
packages/fiori/src/ShellBar.ts:1507
- The component now queries for '.ui5-shellbar-search-toggle' for the search button. Please ensure all related selectors and references (including in tests) are updated consistently.
const searchToggle = this.shadowRoot!.querySelector<HTMLElement>(".ui5-shellbar-search-toggle");
packages/fiori/cypress/specs/ShellBar.cy.tsx:402
- The tests still reference '.ui5-shellbar-search-button' while the component now uses '.ui5-shellbar-search-toggle'. Please update the test selectors to match the new class names.
.find(".ui5-shellbar-search-button")
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
PetyaMarkovaBogdanova
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ShellBar search functionality to support two separate collapse modes for search fields.
Changes
Dual Mode Support:
Allows self-collapsible search with an internal toggle and collapsed property or fully custom search with its own button.
Syncing Mechanism:
The two collapse mechanisms are now synchronized using the showSearchField getter/setter instead of a combined property.
Customization Options:
New properties
hideSearchButtonanddisableAutoSearchFieldenable further customization of custom search fields.Accessibility Improvements:
Roles and labels are correctly set for the content items container.
New Features:
A new
search-field-toggleevent is fired when the search field is toggled by internal rules, and a new gettersearchButtonRefis available for managing focus on the search button.