fix(ui5-side-navigation): prevent text squeezing during expand animation - #13774
Merged
Conversation
s-todorova
temporarily deployed
to
netlify-preview
July 2, 2026 06:34 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
|
🚀 Deployed on https://pr-13774--ui5-webcomponents-preview.netlify.app |
TeodorTaushanov
requested changes
Jul 2, 2026
s-todorova
force-pushed
the
sidenav_animation
branch
from
July 3, 2026 12:00
9b88f11 to
12c635e
Compare
s-todorova
temporarily deployed
to
netlify-preview
July 3, 2026 12:00 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
July 6, 2026 19:07 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
July 7, 2026 06:29 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
July 8, 2026 09:53 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
July 8, 2026 10:46 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
July 8, 2026 12:59 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
July 8, 2026 13:09 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
July 13, 2026 06:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
TeodorTaushanov
requested changes
Jul 14, 2026
TeodorTaushanov
left a comment
TeodorTaushanov
left a comment
Member
There was a problem hiding this comment.
AI review:
- Add a fallback timeout (e.g., 500ms) to reset _bAnimating if transitionend doesn't fire
- Reset _bAnimating = false in onExitDOM
- Check getAnimationMode() !== AnimationMode.None before activating animation machinery
s-todorova
temporarily deployed
to
netlify-preview
July 20, 2026 13:44 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
July 21, 2026 05:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
July 21, 2026 08:18 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
July 22, 2026 11:14 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
July 22, 2026 11:17 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
July 23, 2026 07:41 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
s-todorova
temporarily deployed
to
netlify-preview
July 23, 2026 12:28 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
TeodorTaushanov
approved these changes
Jul 23, 2026
s-todorova
temporarily deployed
to
netlify-preview
July 23, 2026 12:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
|
🧹 Preview deployment cleaned up: https://pr-13774--ui5-webcomponents.netlify.app |
|
🎉 This PR is included in version v2.25.0 🎉 The release is available on v2.25.0 Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #13546