feat(ui5-user-settings-dialog): add saveMode with Save/Cancel footer - #13845
Merged
Conversation
Add a boolean `saveMode` property (default false, backward-compatible). When enabled, the footer renders Save (Emphasized) and Cancel buttons instead of the default Close button, each firing a corresponding non-cancelable event. The application is responsible for closing the dialog after persisting or discarding the changes. - Add `save` and `cancel` event decorators and handlers - Add Save/Cancel button i18n keys and getters - Add SaveMode website sample (HTML, JS, React) with a confirmation dialog - Document the Save Mode under More Samples - Add Cypress specs covering the save-mode footer and events - Demonstrate save-mode in the dev test page
dobromiraboycheva
temporarily deployed
to
netlify-preview
July 20, 2026 07:44 — with
GitHub Actions
Inactive
dobromiraboycheva
temporarily deployed
to
netlify-preview
July 20, 2026 07:45 — with
GitHub Actions
Inactive
|
🚀 Deployed on https://pr-13845--ui5-webcomponents-preview.netlify.app |
…Mode React sample UI5 component wrappers accept `class`, not `className`. Replace it on the Panel, Text, Label and Select wrappers to fix the sample typecheck.
dobromiraboycheva
temporarily deployed
to
netlify-preview
July 20, 2026 08:34 — with
GitHub Actions
Inactive
…footer-save-mode # Conflicts: # packages/fiori/test/pages/UserSettingsDialog.html
dobromiraboycheva
temporarily deployed
to
netlify-preview
July 21, 2026 07:03 — with
GitHub Actions
Inactive
dobromiraboycheva
temporarily deployed
to
netlify-preview
July 21, 2026 08:28 — with
GitHub Actions
Inactive
dobromiraboycheva
temporarily deployed
to
netlify-preview
July 21, 2026 12:05 — with
GitHub Actions
Inactive
dobromiraboycheva
temporarily deployed
to
netlify-preview
July 21, 2026 12:50 — with
GitHub Actions
Inactive
dobromiraboycheva
temporarily deployed
to
netlify-preview
July 21, 2026 13:26 — with
GitHub Actions
Inactive
SvilenDarvenyashki
requested changes
Jul 21, 2026
Tooltips should only be used on icon-only buttons. The footer Save, Cancel and Close buttons all have visible text, so their redundant tooltip props are removed.
dobromiraboycheva
temporarily deployed
to
netlify-preview
July 21, 2026 15:35 — with
GitHub Actions
Inactive
SvilenDarvenyashki
approved these changes
Jul 21, 2026
dobromiraboycheva
temporarily deployed
to
netlify-preview
July 21, 2026 15:56 — with
GitHub Actions
Inactive
|
🧹 Preview deployment cleaned up: https://pr-13845--ui5-webcomponents.netlify.app |
|
🎉 This PR is included in version v2.25.0 🎉 The release is available on v2.25.0 Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Introducing a new
save-modeproperty to theUserSettingsDialogcomponent, allowing applications to switch the footer from the default "Close" button to explicit Save and Cancel actions.Structure
save-modeis not set (defaultfalse), the footer displays a single "Close" button — the current behavior is unchangedsave-modeis set, the footer displays a Save (Emphasized) and a Cancel button instead of "Close"saveevent; clicking Cancel fires thecanceleventAPI
UserSettingsDialog new property:
saveModebooleanfalseUserSettingsDialog new events:
savecancelUsage
Default footer (Close button):
Save mode (Save + Cancel buttons):
const dialog = document.getElementById("settings"); dialog.addEventListener("save", () => { // persist changes, then close dialog.open = false; }); dialog.addEventListener("cancel", () => { // discard changes, then close dialog.open = false; }); </script>