test(ui5-dialog): stabilize RTL resize anchor test - #13853
Merged
Conversation
GerganaKremenska
temporarily deployed
to
netlify-preview
July 22, 2026 06:42 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
|
🚀 Deployed on https://pr-13853--ui5-webcomponents-preview.netlify.app |
GerganaKremenska
marked this pull request as draft
July 22, 2026 12:24
The "dialog remains anchored after resizing in RTL mode" test was skipped due to an intermittent failure (expected 715 to equal 320). 715 is the dialog's initial width, i.e. the resize occasionally did not register on the 1px-wide resize handle, leaving the dialog unresized. Harden the test instead of changing production logic: - Wait for the resize handle to be visible and grab it at its center. - Drive the pointer in steps so intermediate mousemove events reliably fire the resize handler. - Use closeTo(..., 1) for width / left / right-edge assertions to absorb sub-pixel rounding from getBoundingClientRect. The dialog resize logic is unchanged; the full Dialog spec passes 66/66 across repeated runs. Fixes #13813
GerganaKremenska
force-pushed
the
fix-dialog-rtl-resize-anchor
branch
from
July 22, 2026 12:42
6dc0d54 to
b4db82b
Compare
GerganaKremenska
changed the title
GerganaKremenska
marked this pull request as ready for review
July 23, 2026 07:38
TeodorTaushanov
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
dialog remains anchored after resizing in RTL modetest was skipped due to an intermittent failure:expected 715 to equal 320.715is the dialog's initial width — meaning the resize occasionally didn't register on the 1px-wide shadow-DOM resize handle, leaving the dialog unresized rather than clamped to its 320px minimum.Investigation showed the dialog resize logic on
mainis correct: with the source unchanged, the fullDialog.cy.tsxspec passes 66/66 across repeated isolated and full-spec runs. The failure is test flakiness, not a product bug, so this fix is test-only — no production code changes.Changes
packages/main/cypress/specs/Dialog.cy.tsx:realMouseDown({ position: "center" })).mousemoveevents reliably fire the resize handler.closeTo(..., 1)for width / left / right-edge assertions to absorb sub-pixel rounding fromgetBoundingClientRect.Testing
Dialog.cy.tsxpasses 66/66 across 3 repeated full-spec runs with the unchanged dialog logic.Fixes #13813