Skip to content

fix(ui5-side-navigation): correct overflow items visibility calculation - #13871

Merged
TeodorTaushanov merged 20 commits into
mainfrom
sidenav_overlap
Aug 31, 2026
Merged

fix(ui5-side-navigation): correct overflow items visibility calculation#13871
TeodorTaushanov merged 20 commits into
mainfrom
sidenav_overlap

Conversation

@TeodorTaushanov

@TeodorTaushanov TeodorTaushanov commented Jul 28, 2026

Copy link
Copy Markdown
Member

The overflow logic now properly accounts for separators, margins,
and sub-pixel rounding when determining which items to hide.
Items and their adjacent separators are hidden together to prevent
orphaned separators.

fixes #13788

@sap-ui5-webcomponents-release

Copy link
Copy Markdown

@TeodorTaushanov TeodorTaushanov changed the title fix(ui5-side-navigation): fix overlapping issue wip(ui5-side-navigation): fix overlapping issue Jul 28, 2026
@TeodorTaushanov TeodorTaushanov changed the title wip(ui5-side-navigation): fix overlapping issue fix(ui5-side-navigation): fix collapsed mode overlapping issue Jul 31, 2026
@TeodorTaushanov TeodorTaushanov changed the title fix(ui5-side-navigation): fix collapsed mode overlapping issue fix(ui5-side-navigation): correct overflow items visibility calculation Jul 31, 2026
@TeodorTaushanov
TeodorTaushanov requested a review from a team July 31, 2026 10:08
Comment thread packages/fiori/cypress/specs/SideNavigation.cy.tsx Outdated
Comment thread packages/fiori/src/SideNavigation.ts Outdated
@TeodorTaushanov
TeodorTaushanov merged commit e486764 into main Aug 31, 2026
13 checks passed
@TeodorTaushanov
TeodorTaushanov deleted the sidenav_overlap branch August 31, 2026 11:20
@sap-ui5-webcomponents-release

Copy link
Copy Markdown

🧹 Preview deployment cleaned up: https://pr-13871--ui5-webcomponents.netlify.app

@sap-ui5-webcomponents-release

Copy link
Copy Markdown

🎉 This PR is included in version v2.27.0-rc.1 🎉

The release is available on v2.27.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SideNavigation in collapsed mode items of top group overlap with items of fixed bottom group

2 participants