fix(ui5-user-settings-dialog): use default list role instead of menu - #13934
Merged
Conversation
|
🚀 Deployed on https://pr-13934--ui5-webcomponents-preview.netlify.app |
dobromiraboycheva
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The side navigation List in UserSettingsDialog used accessibleRole="Menu", rendering role="menu" on the list and role="menuitem" on its items. This put screen readers into menu-interaction mode, which caused several accessibility problems:
Removing the Menu role lets the List use its default list role, which matches the ListItemStandard children. The dialog is now announced correctly, and arrow-key list navigation is announced properly.
Added a Cypress test verifying the list exposes role="list" (not menu) and that items don't inherit role="menuitem".