fix(ui5-calendar): translate week number aria-label in DayPicker - #14014
Merged
Conversation
The aria-label on the week number container (`ui5-dp-weekname-container`)
was hardcoded as an English template literal `Calendar Week ${weekNum}`,
bypassing the i18n bundle and making it untranslatable.
Added a new i18n key `DAY_PICKER_CALENDAR_WEEK` with a `{0}` placeholder
for the week number, and routed the aria-label through
`DayPicker.i18nBundle.getText()` via a new `_getCalendarWeekLabel()` method.
Fixes: #14003
unazko
temporarily deployed
to
netlify-preview
September 2, 2026 06:49 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
1 task
|
🚀 Deployed on https://pr-14014--ui5-webcomponents-preview.netlify.app |
unazko
temporarily deployed
to
netlify-preview
September 2, 2026 07:02 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
NHristov-sap
approved these changes
Sep 3, 2026
unazko
temporarily deployed
to
netlify-preview
September 3, 2026 12:44 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
|
🧹 Preview deployment cleaned up: https://pr-14014--ui5-webcomponents.netlify.app |
|
🎉 This PR is included in version v2.27.0-rc.1 🎉 The release is available on v2.27.0-rc.1 Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The aria-label on the week number cells in the calendar was hardcoded
in English ("Calendar Week 52"), so screen readers would always announce
it in English regardless of the user's language setting.
Solution:
Added a new i18n key
DAY_PICKER_CALENDAR_WEEKand routed the aria-labelthrough the i18n bundle, so it will be announced in the user's language
once translations are provided.
No automated test is included since the translation files for other locales
are maintained by the translation team and are not yet available. The fix
was verified manually using the German locale.
Fixes: #14003