Skip to content

fix(frontend): update restart notice wording#1710

Merged
UNIkeEN merged 1 commit into
UNIkeEN:mainfrom
baiyuansjtu:fix002
Jun 14, 2026
Merged

fix(frontend): update restart notice wording#1710
UNIkeEN merged 1 commit into
UNIkeEN:mainfrom
baiyuansjtu:fix002

Conversation

@baiyuansjtu

@baiyuansjtu baiyuansjtu commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Checklist

  • Changes have been tested locally and work as expected.
  • All tests in workflows pass successfully.
  • Documentation has been updated if necessary.
  • Code formatting and commit messages align with the project's conventions.
  • Comments have been added for any complex logic or functionality if possible.

This PR is a ..

  • 🆕 New feature
  • 🐞 Bug fix
  • 🛠 Refactoring
  • ⚡️ Performance improvement
  • 🌐 Internationalization
  • 📄 Documentation improvement
  • 🎨 Code style optimization
  • ❓ Other (Please specify below)

Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • e.g. close #xxxx, fix #xxxx

Description

  • Please insert your description here and provide info about the "what" this PR is solving.

Additional Context

  • Add any other relevant information or screenshots here.

Summary by Sourcery

Enhancements:

  • Refresh restart notice text in English and all supported non-English locale JSON files for clearer, more consistent messaging.

@sourcery-ai

sourcery-ai Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the restart-related user-facing message text across all supported locales by adjusting the relevant entries in the locale JSON files, without changing any runtime logic.

File-Level Changes

Change Details Files
Update restart notice wording in all supported locales.
  • Modify the English restart notice string to use the new phrasing while keeping the same message key.
  • Adjust the corresponding restart notice translations in French, Japanese, Literary Chinese (lzh), Simplified Chinese, and Traditional Chinese locale files to align with the updated English text.
  • Ensure JSON structure, keys, and syntax remain unchanged apart from the updated string values.
src/locales/en.json
src/locales/fr.json
src/locales/ja.json
src/locales/lzh.json
src/locales/zh-Hans.json
src/locales/zh-Hant.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 14, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@UNIkeEN UNIkeEN left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他语言全都核对过和 智能 设置那里一致吗(都意为重启后生效?)

以及为什么有些文件单独改了 3107 行但是看起来什么都没改()

@3gf8jv4dv

Copy link
Copy Markdown
Contributor

其他语言全都核对过和 智能 设置那里一致吗(都意为重启后生效?)

看了眼,英语和繁中的意思没问题。

以及为什么有些文件单独改了 3107 行但是看起来什么都没改()

看 patch 说是换行符的问题

https://github.com/UNIkeEN/SJMCL/commit/aa508f1b8798d4bf02fb0c539c0ace0588800839.patch

@UNIkeEN
UNIkeEN merged commit 1766f24 into UNIkeEN:main Jun 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants