Error message in logs: Use of uninitialized value...

[dani-sanchez-dorado]

Hello,

I've recently update ravada to the last version (2.4.0) and now, this message appears constantly in logs:

Jul  7 17:15:43 elora rvd_back[432526]: Use of uninitialized value $args{"f"} in concatenation (.) or string at /usr/share/perl5/Ravada.pm line 6290.
Jul  7 17:15:43 elora rvd_back[432526]: Use of uninitialized value $args{"f"} in concatenation (.) or string at /usr/share/perl5/Ravada.pm line 6290.
Jul  7 17:17:45 elora rvd_back[432609]: Use of uninitialized value $args{"f"} in concatenation (.) or string at /usr/share/perl5/Ravada.pm line 6290.
Jul  7 17:17:45 elora rvd_back[432609]: Use of uninitialized value $args{"f"} in concatenation (.) or string at /usr/share/perl5/Ravada.pm line 6290.
Jul  7 17:17:45 elora rvd_back[432609]: Use of uninitialized value $args{"f"} in concatenation (.) or string at /usr/share/perl5/Ravada.pm line 6290.
Jul  7 17:17:45 elora rvd_back[432609]: Use of uninitialized value $args{"f"} in concatenation (.) or string at /usr/share/perl5/Ravada.pm line 6290.
Jul  7 17:19:47 elora rvd_back[432739]: Use of uninitialized value $args{"f"} in concatenation (.) or string at /usr/share/perl5/Ravada.pm line 6290.
Jul  7 17:19:47 elora rvd_back[432739]: Use of uninitialized value $args{"f"} in concatenation (.) or string at /usr/share/perl5/Ravada.pm line 6290.
Jul  7 17:19:47 elora rvd_back[432739]: Use of uninitialized value $args{"f"} in concatenation (.) or string at /usr/share/perl5/Ravada.pm line 6290.
Jul  7 17:19:47 elora rvd_back[432739]: Use of uninitialized value $args{"f"} in concatenation (.) or string at /usr/share/perl5/Ravada.pm line 6290.

I haven't detected any problem in my system, all seens to work fine.

Thanks!

Server:
root@elora:/var/adm/syslog# cat /etc/os-release
NAME="Ubuntu"
VERSION="20.04 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04 LTS"
VERSION_ID="20.04"

With all libraries updated.

Ravada version: 2.4.0

[frankiejol]

Hello @dani-sanchez-dorado this should fix this warning , replace /usr/share/perl5/Ravada.pm with:

my $rule = join(" ", map { $_." ".($args{$_} or '') } sort keys %args);

If you confirm it works, I add it to the next version.

Anyway I wonder how the iptables f is undefined, you may add this line to dump the contents:

warn Dumper(\%args) if exists $args{f} && !defined $args{f}

[dani-sanchez-dorado]

Hello!
the message has dissapear now.
I add the debug line to the code, but has one error. Missing ";" at the end.
Fix with:

warn Dumper(\%args) if exists $args{f} && !defined $args{f} ;

Thanks!!