test: check ISO images entries are unique#2326
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a repository-level test to ensure iso_images entries don’t accidentally duplicate key identifying fields, helping catch regressions in ISO metadata (especially around file_re mistakes).
Changes:
- Introduces
test_unique_entries()to assert uniqueness ofname,description,file_re, and a derivedurl + file_rekey. - Runs the new uniqueness test as part of
t/repository/10_iso.t.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifies names, descriptions and file regexp are unique. URLs may be duplicated but not concatenated with the file_re.
This will spot mistakes specially when file_re that happened in the past.