Fix wrong query parameter name for blob. #1498
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielTOsborne
force-pushed
the
fixes/blob-query
branch
from
dfdd7c7 to
44f48e0
Compare
MikeNeilson
reviewed
Dec 12, 2025
| thewar: ${{steps.thebuild.outputs.WARFILE}} | ||
| steps: | ||
| - name: Clean up disk space, so we don't run out. | ||
| if: matrix.platform == 'ubuntu-latest' |
Contributor
There was a problem hiding this comment.
Suggested change
| if: matrix.platform == 'ubuntu-latest' |
I just realized this block probably isn.t even running since the platform isn't in the matrix. On my fork I got "disk out of space" and after removing that tests are actually running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1483.
Forgot to fix the query name. I think I considered making the parameter the same (just 'id') across both blob and clob, but changed my mind and forgot to adjust blob.