Enhancements/blob clob query #1483
Conversation
DanielTOsborne
force-pushed
the
enhancements/blob-clob-query
branch
from
f54117c to
734ce80
Compare
MikeNeilson
left a comment
MikeNeilson
left a comment
There was a problem hiding this comment.
The change itself is good. We'd already done similar for a portion of the clob end point.
However, the explanation text is incorrect.
The inability to use / in the path parameter is due to limitations in pattern matching.
…ielTOsborne/cwms-radar-api into enhancements/blob-clob-query
So, I didn't originally write that, I just copied what was already there: https://github.com/USACE/cwms-data-api/blob/develop/cwms-data-api/src/main/java/cwms/cda/api/ClobController.java#L159 |
well, now, that's quite a reasonable thing to do then isn't it. I'll go suggest updated text inline to accept. |
MikeNeilson
left a comment
MikeNeilson
left a comment
There was a problem hiding this comment.
Suggested text provided.
Add blob-id or clob-id query parameter, respectively, to all required methods, so ones with invalid path characters can be referenced. This is required for HydrologicEngineeringCenter/cwms-cli#72
…ilters * origin: Entity endpoint Controller and Integration test (#1497) Enhancements/blob clob query (#1483) Update treafik for latest docker. (#1493) Bugfix/cda 45 ts vertical datum (#1344) CDA-66: Updated TS identifier descriptor paging (#1481) add in missing expiration date to constant/seasonal levels (#1490) 1351 implement cda gui code formatter (#1460) add missing back tic CWMS Data API documentation /timeseries GET endpoints. (#1476) CDA-60: Accept Header Formatting Documentation (#1463) The temp users set needs to be a LinkedHashSet, otherwise the last user in the list isn't always the last user and the paging doesn't work. Add static analysis unit test for Controller classes (#1362) Bugfix/incorrect parameter warning cda 58 (#1470) Test updates for latest schema and correct release schema image. (#1474) CDA-54 - Implements Entity DTO and Dao (#1482) Update npm pacakges (#1478) Correct required java version (#1462) CDA-40: Exception Handling Implementation Updates (#1358)
2 participants
Add blob-id or clob-id query parameter, respectively, to all required methods, so ones with invalid path characters can be referenced.
This is required for HydrologicEngineeringCenter/cwms-cli#72