This repository was archived by the owner on May 28, 2024. It is now read-only.
Replace hard-coded prediction dates in Snakefile_base.smk#174
Merged
lekoenig merged 1 commit intoUSGS-R:mainfrom Nov 16, 2022
Merged
Conversation
jsadler2
approved these changes
Nov 16, 2022
Collaborator
|
I was thinking we should do the validation end date just to keep the test set further hidden away |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small PR to replace hard-coded start and end dates for the predictions step in
Snakefile_base.smkwith dates that get pulled from the config files. I tried running the pipeline with this edit on tallgrass and it seemed to work fine.@jsadler2, can you remind me why the
pred_end_dateis equal to theval_end_date(as opposed to thetest_end_date)?Closes #171.