feat: Add iter method and Iterator class to _ds.pyi - #283
Merged
Conversation
Sync type stubs with ds.cc to include: - Search.iter() method returning Iterator - Chain.iter() method returning Iterator - New Iterator class with next() method Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the _ds Python type stubs to reflect the underlying C++ bindings by adding an explicit iterator-based API for Search and Chain.
Changes:
- Add
Search.iter()returning a new_ds.Iterator. - Add
Chain.iter()returning a new_ds.Iterator. - Introduce
_ds.Iteratorstub with anext()method returningOptional[Rule].
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+750
to
+756
| """Iterator for Search and Chain results.""" | ||
|
|
||
| def next(self) -> Optional[Rule]: | ||
| """Get the next rule in the iteration. | ||
|
|
||
| Returns: | ||
| The next Rule object, or None if iteration is complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync type stubs with ds.cc to include: