Skip to content

Fix dev container: remove pyright, use apt for cmake, remove auto-sync - #58

Merged
hzhangxyz merged 2 commits into
mainfrom
copilot/remove-pyright-issue
Nov 28, 2025
Merged

Fix dev container: remove pyright, use apt for cmake, remove auto-sync#58
hzhangxyz merged 2 commits into
mainfrom
copilot/remove-pyright-issue

Conversation

Copilot AI commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

Dev container had three issues: redundant pyright extension conflicting with Pylance, problematic cmake feature, and unwanted auto-sync of dependencies on container creation.

Changes

  • devcontainer.json: Remove ms-pyright.pyright extension (Pylance includes pyright functionality)
  • devcontainer.json: Remove ghcr.io/devcontainers-extra/features/cmake:1 feature
  • post-create.sh: Add cmake to apt-get install
  • post-create.sh: Remove uv sync --locked --extra dev, npm ci --include=dev, and pre-commit install

Developers now manually run dependency sync and pre-commit setup as needed.

Original prompt

This section details on the original issue you should resolve

<issue_title>dev container 依然不够完善。</issue_title>
<issue_description>1. pyright似乎是多余的, 应该删掉

Pyright has detected that the Pylance extension is installed. Pylance includes the functionality of Pyright, and running both of these extensions can lead to problems. Pyright will disable itself. Uninstall or disable Pyright to avoid this message.
  1. cmake 这个 feature 有点问题, 请使用apt来完成cmake的安装, 而不是使用feature

  2. uv sync --locked --extra dev 和 npm ci --include=dev 应该开发的时候手动同步, 不要写在dev container的脚本里, pre commit 也不要写在里面。
    </issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…c commands

Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
@hzhangxyz
hzhangxyz marked this pull request as ready for review November 28, 2025 15:04
Copilot AI changed the title [WIP] Remove Pyright and update dev container setup Fix dev container: remove pyright, use apt for cmake, remove auto-sync Nov 28, 2025
Copilot AI requested a review from hzhangxyz November 28, 2025 15:05
@hzhangxyz
hzhangxyz merged commit 926e20e into main Nov 28, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dev container 依然不够完善。

2 participants