Fix dev container: remove pyright, use apt for cmake, remove auto-sync - #58
Merged
Conversation
…c commands Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
hzhangxyz
approved these changes
Nov 28, 2025
hzhangxyz
marked this pull request as ready for review
November 28, 2025 15:04
Copilot
AI
changed the title
[WIP] Remove Pyright and update dev container setup
Fix dev container: remove pyright, use apt for cmake, remove auto-sync
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev container had three issues: redundant pyright extension conflicting with Pylance, problematic cmake feature, and unwanted auto-sync of dependencies on container creation.
Changes
ms-pyright.pyrightextension (Pylance includes pyright functionality)ghcr.io/devcontainers-extra/features/cmake:1featurecmaketo apt-get installuv sync --locked --extra dev,npm ci --include=dev, andpre-commit installDevelopers now manually run dependency sync and pre-commit setup as needed.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.