Nightly CI builds failing - Link Changes - #1675
Conversation
|
|
|
Still failed: https://github.com/UXARRAY/uxarray/actions/runs/31812018032/job/94804672219 |
|
Full CI run seems to be working now after the changes to 403 and reformatting links on the citation page: We had to do some reformatting to links on the new citation page
Example — the link on the citations page: Old: `Descriptors <api.html#descriptors>`__
New: :ref:`Descriptors <descriptors>`And the matching label we added in .. _descriptors:
Descriptors
~~~~~~~~~~~A few valid links (Stack Overflow, SIAM DOIs) were added to |
Sevans711
left a comment
There was a problem hiding this comment.
All looks good to me! Let's merge to main.
Flagging a related issue I just opened: #1676. My idea is that we might solve two problems at once by adding a run-link-check label which works similarly to the run-benchmark label, as way to opt-in to link-check for a given PR. That would make it easier to debug things like this in the future (no need to find the "run jobs" button separately). But, probably more importantly, it would also reduce the chances for docs-editing PRs like #1635 to cause link-check to fail on main without ever realizing link-check might be a problem.
Closes #1638
Overview
We noticed builds failing, and it may be due to a link check issue. Stackoverflow is rejecting bots to check the link so it may need to be changed, moved, or removed
Changes:
PR Checklist
General
Testing & Benchmarking
Documentation
docs/api.rst_)Examples
docs/examples/; guide:docs/user-guide/; quickstart:docs/getting-started/)docs/gallery.rst; guide:docs/userguide.rst; quickstart:docs/quickstart.rst)docs/gallery.ymlwith appropriate thumbnail photo indocs/_static/thumbnails/AI Disclosure
AI Usage: Claude Code