Fix extremely bad bug that incorrectly exited the linear move #69
Merged
mjstn merged 1 commit intokinetic-develfrom Oct 1, 2020
Merged
Fix extremely bad bug that incorrectly exited the linear move #69mjstn merged 1 commit intokinetic-develfrom
mjstn merged 1 commit intokinetic-develfrom
Conversation
…use of incorrect absolute value function.
rohbotics
approved these changes
Oct 1, 2020
Member
rohbotics
left a comment
rohbotics
left a comment
There was a problem hiding this comment.
Doh! I can't believe that wasn't caught earlier, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having a heck of a time with move basic exiting without moving forward at all.
Issue is the abs(remaining.x()) was used when we must use std::abs(remaining.x())
Without this fix move basic is close to useless ! This is an urgent fix!
I don't know what is on our images. The image may be ok, don't know.