Skip to content

Add diagnostics skills for productivity activities#787

Merged
MarinRzv merged 1 commit into
mainfrom
feat/productivity-activities-diagnostics-skills
May 21, 2026
Merged

Add diagnostics skills for productivity activities#787
MarinRzv merged 1 commit into
mainfrom
feat/productivity-activities-diagnostics-skills

Conversation

@alinac24S

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Claude finished @alinac24S's task in 2m 49s —— View job


PR Review: Add diagnostics skills for productivity activities

  • Gather context and read review criteria
  • Read full diff and all changed files
  • Check skill structure and conventions
  • Check for cross-skill references, secrets, broken links
  • Verify CODEOWNERS and test coverage
  • Post final review

Summary

Adds diagnostics playbooks for two new activity packages — Google Workspace (gsuite-activities) and Microsoft Office 365 (o365-activities) — under the existing uipath-diagnostics skill. Each package gets an overview, investigation guide, presentation rules, summary table, and 5–7 error-specific playbooks. Also removes the [*] array-field documentation from uipath-maestro-flow.

Change-by-Change Review

1. skills/uipath-diagnostics/references/summary.md (modified)

Severity: Low

Two new sections added for Google Workspace and O365 activities — structure mirrors existing sections (Orchestrator, System Activities, etc.). All relative links resolve correctly.

Minor: double blank line at line 74–75 between the O365 section and the ## Playbooks section. Cosmetic only.

2. gsuite-activities/overview.md (new)

Severity: OK

Comprehensive overview covering Gmail, Drive, and Sheets activity types with clear failure pattern descriptions. Well-structured — activity types are grouped by Google service, failure patterns are grouped the same way. All activity class names are specific and accurate-looking.

3. gsuite-activities/investigation_guide.md (new)

Severity: OK

Data correlation rules and testing prerequisites. Follows the same structure as existing investigation guides (system-activities, ui-automation). File uses underscores (investigation_guide.md) which is inconsistent with the repo convention of kebab-case, but matches the existing pattern used by all other activity packages in this skill — consistent within the skill.

4. gsuite-activities/presentation.md (new)

Severity: OK

Presentation rules for how to refer to Google Workspace entities (activities, connections, Drive items, sheets, labels, etc.). Well-written with concrete examples.

5. gsuite-activities/summary.md (new)

Severity: OK

Index table linking to all 7 GSuite playbooks with confidence levels and descriptions. All relative links to ./playbooks/*.md resolve correctly.

6. GSuite playbooks (7 new files)

Severity: OK

All 7 playbooks follow the established ## Context / ## Investigation (optional) / ## Resolution pattern. Each has YAML frontmatter with confidence: high or confidence: medium. Content is thorough — each playbook lists exact error messages, which activities produce the error, root causes, differential diagnosis ("Different cause, do not apply this playbook"), and actionable resolution steps. Quality is high across the board.

7. o365-activities/overview.md (new)

Severity: Medium

Good overall coverage of Mail, Files, and Excel activity types. However, there's a ConflictBehavior vs ConflictResolution naming inconsistency:

  • Line 22: Mail download operations say ConflictBehavior enum governs duplicate behavior
  • Line 41 (Common Failure Patterns > Mail): refers to ConflictResolution = Fail for DownloadEmailConnections
  • Line 28: Files download says ConflictResolution governs duplicate filename behavior

These are different enum names on different activities, but the inconsistency between lines 22 and 41 for the same activities (DownloadEmailConnections, DownloadEmailAttachments) could confuse an agent. Fix this →

8. o365-activities/investigation_guide.md (new)

Severity: OK

Mirrors the GSuite investigation guide structure. Adds O365-specific data correlation rules (mailbox scoping, drive resolution evidence, package version). Well-written.

9. o365-activities/presentation.md (new)

Severity: Low

Line 13: The header says ConflictBehavior values but the example inside uses ConflictResolution = Rename. This could mislead an agent into mixing up the two enum names. The O365 package uses ConflictBehavior for remote-side operations and ConflictResolution for local-side download operations — the presentation rule should clarify both, or at minimum the example should match the header. Fix this →

10. o365-activities/summary.md (new)

Severity: OK

Index table with 5 playbook entries. All relative links resolve.

11. O365 playbooks (5 new files)

Severity: Low

All follow the established pattern. One minor issue in download-multiple-items-name-conflict.md line 35: ConflictResolution(conflict behavior) — the parenthetical should either be removed or formatted consistently (e.g., ConflictResolution / ConflictBehavior — whichever the activity actually uses for that property).

The drive-item-not-found.md playbook is the most thorough — 59 lines covering 7 distinct root causes with a clear resolution checklist. Excellent diagnostic content.

12. uipath-maestro-flow changes (CAPABILITY.md + connector/impl.md)

Severity: Medium — scoping concern

This PR removes the [*] array-field documentation from the uipath-maestro-flow skill:

  • CAPABILITY.md: Removes one Critical Rule bullet about [*] in connector parameter keys
  • connector/impl.md: Removes the full array-fields table and explanation from Step 6b, plus one troubleshooting table row

These deletions are unrelated to the diagnostics skill addition and modify a different skill entirely (uipath-maestro-flow). Per repo conventions: "Changes are scoped to the skill being modified — no drive-by changes to unrelated skills." This should be in a separate PR or at minimum explained in the PR description.

What's Missing

  • PR description is empty — "No description provided." Given the PR touches two skills and removes content from uipath-maestro-flow, a description explaining the rationale would help reviewers.
  • No e2e test tasks for the new playbooks — there are existing test tasks under tests/tasks/uipath-diagnostics/ but none covering GSuite or O365 activity diagnostics. Medium — flagging per review criteria, though most diagnostic playbooks don't have task coverage yet.
  • Extra blank line in references/summary.md at line 74 (double blank line before ## Playbooks). Cosmetic.

Area Ratings

Area Status Notes
Frontmatter OK No SKILL.md changes; existing frontmatter is valid
E2E Tests Issue No new test tasks for GSuite/O365 diagnostics (Medium — consistent with other activity packages)
Skill Body OK No SKILL.md body changes
References & Assets Issue ConflictBehavior/ConflictResolution naming inconsistency in O365 docs (Medium)
Repo Hygiene Issue Out-of-scope changes to uipath-maestro-flow (Medium); CODEOWNERS already covers /skills/uipath-diagnostics/

Issues for Manual Review

  • ConflictBehavior vs ConflictResolution domain accuracy (O365) — The O365 package appears to use ConflictBehavior for remote-side operations (Create Folder, Upload, Copy, Move, Rename, Create Workbook, Add Sheet) and ConflictResolution for local-side download operations. The overview, presentation rules, and download playbook mix these inconsistently. A domain expert should confirm which enum name each activity actually exposes.
  • [*] array-field removal from maestro-flow — The PR removes documentation about how to handle [*] array markers in connector parameters. A maestro-flow maintainer should confirm this guidance is no longer needed (e.g., if the CLI now handles this automatically).
  • Playbook technical accuracy — The error messages, activity class names, and resolution steps look thorough and internally consistent, but domain experts should verify they match the actual runtime behavior of UiPath.GSuite.Activities and UiPath.MicrosoftOffice365.Activities.

Conclusion

The GSuite and O365 diagnostics content is high quality — well-structured playbooks with exact error messages, clear differential diagnosis, and actionable resolution steps. The content follows established patterns from existing activity-package diagnostics.

Two items to address before merge:

  1. Scope: The uipath-maestro-flow changes should be split into a separate PR or justified in the PR description.
  2. Consistency: The ConflictBehavior/ConflictResolution naming should be verified against the actual activity API and made consistent across the O365 files.

@alinac24S alinac24S force-pushed the feat/productivity-activities-diagnostics-skills branch 2 times, most recently from 060c4d2 to 6e9c652 Compare May 19, 2026 12:01
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Smoke test coverage gap — the following changed skills have no tests under tests/tasks/:

  • uipath-diagnostics

Consider adding smoke tests before merging.

@alinac24S alinac24S force-pushed the feat/productivity-activities-diagnostics-skills branch from 6e9c652 to 7188522 Compare May 20, 2026 08:30
@MarinRzv MarinRzv merged commit 57cc716 into main May 21, 2026
9 checks passed
@MarinRzv MarinRzv deleted the feat/productivity-activities-diagnostics-skills branch May 21, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants