Improve Maestro BPMN wrapper and packaging guidance#840
Conversation
|
Claude finished @gozhang2's task in 7m 16s —— View job PR Review: Improve Maestro BPMN wrapper and packaging guidance
SummaryThis PR standardizes all wrapper shells to use nested Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | No frontmatter changes; existing SKILL.md not modified |
| E2E Tests | OK | author_validate_pack.yaml updated with corrected validate file path |
| Skill Body | OK | No SKILL.md body changes |
| References & Assets | Issue | HTTP recipe output placement contradicts sibling uipath:mapping pattern; missing shell in wrapper-shells.md |
| Repo Hygiene | OK | CODEOWNERS present, no secrets, no cross-skill refs, all links resolve, changes scoped to one skill |
Issues for Manual Review
- HTTP
uipath:outputplacement — Verify whether the runtime actually expectsuipath:outputinsideuipath:activityforIntsvc.HttpExecution(unlike all other wrappers), or whether it should be inuipath:mapping. If the runtime requires it inside the activity, the recipe is correct and needs an explanatory note; if not, it should be moved. Intsvc.HttpExecutionvsIntsvc.UnifiedHttpRequest— The recipe usesIntsvc.HttpExecution; confirm this is the correct service type for the connectionless manual-mode HTTP pattern (vsUnifiedHttpRequestwhich remains CLI-only).- Test task validate path change — The switch from directory to
.bpmnfile path in the validate command should be confirmed against the current CLI behavior (uip maestro bpmn validate). The PR notes the rerun was "inconclusive: agent timed out."
Conclusion
This is a well-structured documentation refactoring that establishes a clearer, more consistent wrapper pattern across the skill. The sibling uipath:mapping convention, namespace baseline, and legacy shorthand warnings are all valuable additions that will reduce agent mistakes.
Request one change before merge: Resolve the uipath:output placement inconsistency in http-request.md — either move it to uipath:mapping to match the rest of the PR, or add an explicit note explaining why HTTP output lives inside uipath:activity. This is the only place in the PR where the new convention is not followed, and conflicting XML shapes in different reference files will confuse agents.
The remaining items (missing wrapper-shells entry for HTTP, test task verification) are improvements that can land in a follow-up.
|
Claude finished @gozhang2's task in 2m 8s —— View job Coder-eval task lint (advisory)1 task YAML changed; verdicts: 0 Critical, 1 High, 0 Medium, 0 Low, 1 OK. Rubric: .claude/commands/lint-task.md. This check is advisory and never blocks merge. Evidence of passing run❌ High — The changed task
once a successful run is confirmed. (The other Per-task lint
|
* Improve Maestro BPMN wrapper guidance * Clarify Maestro HTTP modeling boundary * Reinforce Maestro two-pass authoring boundary * Centralize Maestro task recipe boundary * Improve Maestro BPMN dogfood guidance * Exclude unsupported Maestro BPMN generation * Improve Maestro BPMN expression validation * Avoid extra draft handoff project files
Summary
uipath:type, siblinguipath:mappingpayload movement, parse-safe XML comments, and draft Intsvc shells.pack, including minimal placeholder-safe metadata shape and a validate-file-path eval update.Validation
git diff --checkbash skills/uipath-maestro-bpmn/.maintenance/check-all.shcoder-eval run tasks/uipath-maestro-bpmn/authoring/api_workflow_task.yaml tasks/uipath-maestro-bpmn/authoring/business_rule_task.yaml -e experiments/e2e.yaml -j 1 --run-dir runs/2026-05-18_pr-wrapper-guidance-api-business- API passed; business timed out in the combined run.coder-eval run tasks/uipath-maestro-bpmn/authoring/business_rule_task.yaml -e experiments/e2e.yaml -j 1 --run-dir runs/2026-05-18_pr-wrapper-guidance-business-reruncoder-eval run tasks/uipath-maestro-bpmn/connector/integration_service_boundary.yaml -e experiments/integration.yaml -j 1 --run-dir runs/2026-05-18_pr-wrapper-guidance-integration-boundary-reruncoder-eval run tasks/uipath-maestro-bpmn/e2e/author_validate_pack.yaml -e experiments/e2e.yaml -j 1 --run-dir runs/2026-05-18_pr-wrapper-guidance-author-validate-pack-rerun- inconclusive: agent timed out before a useful result.