duchuy-new - #6
Open
nguyenduchuy wants to merge 2 commits into
Open
Conversation
Owner
|
Destination branch should be changed from |
|
|
||
| def __init__(self): | ||
| print('The super class is "Human" ') | ||
| name = "" |
There was a problem hiding this comment.
it's much better to use constructor for this purpose.
|
|
||
| class Student(Human): | ||
|
|
||
| marks = [] #list of student's marks |
There was a problem hiding this comment.
add comments before line you want to comment.
Also, please use full sentences:
"List of `Student`'s marks."
|
|
||
| def __init__(self): | ||
| print('Object of class "Student" is created') | ||
| super().__init__() |
There was a problem hiding this comment.
it doesn't make any sense.
Please use a super method properly.
| def get_average_mark(self): | ||
| sum = 0 | ||
| for mark in self.marks: | ||
| sum += mark |
There was a problem hiding this comment.
Wrong variable name.
It looks much easier:
return sum(self.marks)/float(len(self.marks))
Owner
|
@nguyenduchuy it would be great to do something with this pull request. Possible cases are:
As you wish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.