Adding the MINGDA D2

[cataclism]

Hi! Cataclism here! I've worked in order to add the MINGDA D2 to Cura. The base is currently missing but i'll add it soon =)

[Jaime van Kessel (nallath)]

I'm a bit confused by the commit history of this PR. Why does it make all kinds of changes to the artillery_base?

[cataclism]

Jaime van Kessel (@nallath) i don't know why all the history of changes I made in the past are attacched to the PR. Only the last point of the list is the one of interest, all the previous are from my work for the Artillery printers and it has already been approved

[cataclism]

I don't know how to remove it, if you can tell me how to, i'll do it Jaime van Kessel (@nallath)

[Ghostkeeper]

We can squash the commits when merging this.

You can also squash the commits yourself if you'd like to help. There are some instructions online. The basic idea is to do git rebase -i master while on your branch, which comes up with a file editor where you can say which commits need to be squashed into the previous commit. Then afterwards you'd need to force-push.

[Ghostkeeper]

If the profiles for these printers are the same as the Artillery printers, I'd like to propose a change to set the following metadata on all of the new printers:

"quality_definition": "artillery_base"

This tells Cura that you're using the Artillery's profiles. This has three consequences:

• If the Artillery profiles get updated, Mingda profiles will get updated too. This could be good (you get improvements made by the Artillery users as well) or bad (those improvements don't necessarily apply to your printer in some cases, although it might apply in many cases).
• You can then delete these quality profiles. Cura won't need to read these extra ~80 files at every launch, which will save an extra I/O block or two to read from disk.
• Material profiles that apply to Artillery printers will also apply to Mingda. This is something that is currently missing from your PR I think.

You can still override settings in the definition files and nozzle files, but you'd share the quality and material profiles with Artillery then.

[cataclism]

I'll try to squash, hope i can do it!
I'd like to keep them separate since they are different machines. I'll work on it

[Ghostkeeper]

I'd like to keep them separate since they are different machines.

I'd like to deduplicate them if their profiles are the same. If they need to be different that's fine, but if they might be different in the future we can always split the profiles then and deduplicate it now.

[cataclism]

Ok Ghostkeeper , got it. I'm working with the community in order to make the transition to the profiles as smooth as possible. So changhes are coming in the next days

[cataclism]

Ghostkeeper first of all happy new year!!
I've talked with the community and the profiles must be separated.
So If there aren't any problems, you can merge.

[cataclism]

Hope I did everything right! If there are any problems tell me Konstantinos Karmas (@konskarm)

[Konstantinos Karmas (konskarm)]

Alright, since it is decided that the MINGDA definition should be completely separate from the Artillery ones, I will accept this PR. Just make sure to re-use the mingda_base, or else we are adding 88 files for a single printer, which is a bit excessive.