Fix/hide donation on ios - #248
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to hide the donation entry point on iOS in the Settings UI, but it also includes a broad dependency/SDK lockfile update and generated platform file changes that affect desktop builds.
Changes:
- Hide the Settings donation widget on iOS (
Platform.isIOS) in the Settings slider row. - Bump app version and update MSIX metadata in
pubspec.yaml. - Update
pubspec.lock(many dependency upgrades) and regenerate platform plugin registrant/build files.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
lib/modules/settings/presentation/screens/settings_screen.dart |
Conditionally hides the donate widget on iOS. |
pubspec.yaml |
Bumps app version; updates MSIX config (currently inconsistent with app version scheme). |
pubspec.lock |
Large dependency/SDK constraint update (now requires newer Flutter/Dart than CI is pinned to). |
macos/Flutter/GeneratedPluginRegistrant.swift |
Generated registrant changed; currently missing path_provider_foundation import/registration. |
linux/flutter/generated_plugins.cmake |
Generated plugin list updated (adds jni to FFI plugin list). |
windows/flutter/generated_plugins.cmake |
Generated plugin list updated (adds jni to FFI plugin list). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
15
to
19
| import flutter_secure_storage_darwin | ||
| import flutter_timezone | ||
| import package_info_plus | ||
| import path_provider_foundation | ||
| import shared_preferences_foundation | ||
| import url_launcher_macos |
Comment on lines
30
to
34
| FlutterSecureStorageDarwinPlugin.register(with: registry.registrar(forPlugin: "FlutterSecureStorageDarwinPlugin")) | ||
| FlutterTimezonePlugin.register(with: registry.registrar(forPlugin: "FlutterTimezonePlugin")) | ||
| FPPPackageInfoPlusPlugin.register(with: registry.registrar(forPlugin: "FPPPackageInfoPlusPlugin")) | ||
| PathProviderPlugin.register(with: registry.registrar(forPlugin: "PathProviderPlugin")) | ||
| SharedPreferencesPlugin.register(with: registry.registrar(forPlugin: "SharedPreferencesPlugin")) | ||
| UrlLauncherPlugin.register(with: registry.registrar(forPlugin: "UrlLauncherPlugin")) |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
macos/Flutter/GeneratedPluginRegistrant.swift:35
path_provideris a direct dependency (seepubspec.lockentry) andpath_provider_foundationis present inmacos/Podfile.lock, but the generated registrant no longer imports/registers the path provider plugin. If any code (directly or via a dependency) calls intopath_provideron macOS, this will fail at runtime because the plugin won’t be registered. Please re-run the Flutter plugin registrant generation so the correct macOS path_provider implementation is registered, or remove the unusedpath_providerdependency if it’s no longer needed.
func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) {
AudioplayersDarwinPlugin.register(with: registry.registrar(forPlugin: "AudioplayersDarwinPlugin"))
BatteryPlusMacosPlugin.register(with: registry.registrar(forPlugin: "BatteryPlusMacosPlugin"))
ConnectivityPlusPlugin.register(with: registry.registrar(forPlugin: "ConnectivityPlusPlugin"))
FilePickerPlugin.register(with: registry.registrar(forPlugin: "FilePickerPlugin"))
FirebaseAnalyticsPlugin.register(with: registry.registrar(forPlugin: "FirebaseAnalyticsPlugin"))
FLTFirebaseCorePlugin.register(with: registry.registrar(forPlugin: "FLTFirebaseCorePlugin"))
FLTFirebaseCrashlyticsPlugin.register(with: registry.registrar(forPlugin: "FLTFirebaseCrashlyticsPlugin"))
FlutterSecureStorageDarwinPlugin.register(with: registry.registrar(forPlugin: "FlutterSecureStorageDarwinPlugin"))
FlutterTimezonePlugin.register(with: registry.registrar(forPlugin: "FlutterTimezonePlugin"))
FPPPackageInfoPlusPlugin.register(with: registry.registrar(forPlugin: "FPPPackageInfoPlusPlugin"))
SharedPreferencesPlugin.register(with: registry.registrar(forPlugin: "SharedPreferencesPlugin"))
UrlLauncherPlugin.register(with: registry.registrar(forPlugin: "UrlLauncherPlugin"))
WebViewFlutterPlugin.register(with: registry.registrar(forPlugin: "WebViewFlutterPlugin"))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Briefly describe what this PR does and why. Keep it short and clear.
Related Platforms
Verification Checklist
Optional (for bigger changes)
Related Links
Closes #ID.