[pull] master from flameshot-org:master - #261
Merged
Merged
Conversation
* Fix aspect ratio in selection widget when pressing CTRL * Check for height > 0
Since v14 every capture on Linux goes through the org.freedesktop.portal.Screenshot D-Bus portal, but flameshot discarded the reply of the Screenshot call. When no portal backend provides that interface, the call fails within milliseconds. Flameshot then waited for a Response signal that could never arrive and reported a misleading "portal timed out" error, while taking no screenshot at all. Check the reply of the Screenshot call and fail at once with the real D-Bus error. The failure now shows up immediately and names the actual problem, on both Wayland and X11. This does not change which systems can take screenshots. Helps diagnose the reports in #4639.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )