[pull] master from monkeytypegame:master#951
Merged
Merged
Conversation
### Description Fixes: #8119 Problem The FPS input was resetting, even after giving input to it and saving it, once the page is refreshed it shows empty field there again. Cause The FPS input always shows empty field , just because the by default value of the fpsLimit is an empty string ( "") Fix Updated the FPS input handling by adding String(getfpsLimit()) this instead of "" so that valid user-entered values are preserved instead of being reset. The input now correctly reflects the saved FPS value after interacting with the field. ` defaultValues: { fpsLimit: String(getfpsLimit()), }, ` Testing Open Settings and search for "animation fps limit". Enter a custom FPS value. Click away from the input. Once it is saved, Refresh the page and verify that the saved value is still displayed correctly. EDIT: addressed the issue , added a conditional statement, so that the input will not show 1000 and added a if statement to remove the "must be a number" error when selected native --------- Co-authored-by: Christian Fehmer <fehmer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )