fix: qualify cog_planning sibling-module imports with package name#61
Merged
Conversation
cog.py est chargé comme sous-module du package cog_planning
(import_module("cog_planning.cog") dans le chargeur de cogs d'URbot).
Les imports bruts (import info, from const import *, from strings
import *, import settings) ne peuvent donc jamais résoudre les
fichiers voisins du même dossier : ModuleNotFoundError au chargement.
Bot_Presentation, seul autre cog de la même famille, suit déjà la
bonne convention (from cog_presentation import strings/settings,
import cog_presentation.info) : on aligne cog_planning dessus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60
Qualifie les imports de
info/const/strings/settingsdanssrc/cog_planning/cog.pyavec le préfixecog_planning., en miroir de la convention déjà utilisée parBot_Presentation(qui fonctionne).Suite de #58 dans la dockerisation d'URbot.