jacodb-taint-configuration: better IsType condition specializer#208
Merged
lehvolk merged 2 commits intoUnitTestBot:developfrom Dec 14, 2023
Merged
Conversation
Collaborator
Saloed
commented
Dec 11, 2023
Saloed
commented
- Handle the case when package and class matchers are exact after resolving alternatives
- Faster matching for the whole hierarchy
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #208 +/- ##
=============================================
- Coverage 77.01% 77.00% -0.02%
Complexity 1632 1632
=============================================
Files 166 166
Lines 9543 9554 +11
Branches 1693 1697 +4
=============================================
+ Hits 7350 7357 +7
- Misses 1513 1514 +1
- Partials 680 683 +3 ☔ View full report in Codecov by Sentry. |
lehvolk
reviewed
Dec 14, 2023
| cp.hierarchyExt().findSubClasses(cp.objectClass, allHierarchy = true, includeOwn = true) | ||
| if (unresolvedMatchers.isNotEmpty()) { | ||
| val allClassNames = cp.registeredLocations.flatMapTo(hashSetOf()) { | ||
| val names = it.jcLocation?.classNames ?: return@flatMapTo emptyList() |
Collaborator
There was a problem hiding this comment.
This api was not designed for often use so it's better at least to cache it somehow if it's possible
Collaborator
|
Just in case almost all new code is not covered by tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.