Skip to content

Improve TS CFG DSL#340

Merged
Lipen merged 1 commit intoneofrom
lipen/cfg-dsl
Aug 6, 2025
Merged

Improve TS CFG DSL#340
Lipen merged 1 commit intoneofrom
lipen/cfg-dsl

Conversation

@Lipen
Copy link
Copy Markdown
Member

@Lipen Lipen commented Aug 6, 2025

This PR improves CFG DSL by adding boolean/integer/string constants and CustomValue (for arbitrary EtsEntity), and also by refining if/elseif/else stmt builders.

@Lipen Lipen requested a review from CaelmBleidd August 6, 2025 10:26
@Lipen Lipen changed the title [TS] Improve CFG DSL Improve TS CFG DSL Aug 6, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 26.90058% with 125 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.32%. Comparing base (5acbadf) to head (58343b2).
⚠️ Report is 4 commits behind head on neo.

Files with missing lines Patch % Lines
...ain/kotlin/org/jacodb/ets/utils/BlockCfgBuilder.kt 23.95% 66 Missing and 7 partials ⚠️
...c/main/kotlin/org/jacodb/ets/dsl/ProgramBuilder.kt 15.90% 37 Missing ⚠️
...codb-ets/src/main/kotlin/org/jacodb/ets/dsl/DSL.kt 0.00% 11 Missing ⚠️
...odb-ets/src/main/kotlin/org/jacodb/ets/dsl/Expr.kt 80.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #340      +/-   ##
============================================
- Coverage     69.53%   69.32%   -0.21%     
+ Complexity     2492     2491       -1     
============================================
  Files           275      275              
  Lines         15646    15715      +69     
  Branches       2354     2361       +7     
============================================
+ Hits          10879    10894      +15     
- Misses         3837     3885      +48     
- Partials        930      936       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 6, 2025

Test Results

  215 files  ±0    215 suites  ±0   15m 54s ⏱️ +3s
  711 tests ±0    699 ✅ ±0  12 💤 ±0  0 ❌ ±0 
1 977 runs  ±0  1 927 ✅ ±0  50 💤 ±0  0 ❌ ±0 

Results for commit 58343b2. ± Comparison against base commit 5acbadf.

Comment thread jacodb-ets/src/main/kotlin/org/jacodb/ets/dsl/ProgramBuilder.kt
Comment thread jacodb-ets/src/main/kotlin/org/jacodb/ets/utils/BlockCfgBuilder.kt
@Lipen Lipen merged commit 213f9a1 into neo Aug 6, 2025
9 of 11 checks passed
@Lipen Lipen deleted the lipen/cfg-dsl branch August 6, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants