fix(deploy): fix git ref verify - #175
Merged
Merged
Conversation
|
+1. Just ran into this same issue. It looks like a branch can be supplied as the next param, but the documentation doesn't say anything about that. It'd be great to see this fix applied, or the docs updated with the proper way to specify a ref hash. In order to work around this, we ended up adding a pre-deploy hook which runs a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem is encountered when deploying with
pm2 deploy ref ref_hash.git rev-parse --quiet --verify ${ref_hash}does not check ifref_hashreally exists, it only checks if the format is valid.For example, the command can be executed under the current repo: