Update 8.x.x stereo tests from LegacyXR to XRSDK (backport PR 267) #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m toggling it off for now.
…erry pick PR 267 commit d8a4af4.)
DennisDeRykeUnity
changed the title
stramit
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Stereo tests recently began failing on Unity 2020.1 with Graphics 8.x.x after the following PR was merged.
PR 107886 "Disable legacy VR and warn user"
https://ono.unity3d.com/unity/unity/pull-request/107886/_/2020.1/xr/disable-builtin-vr-if-detected
This was because the stereo tests in Graphics 8.x.x were still using LegacyXR (aka BuiltIn VR). This PR updates the stereo Shader Graph tests and the stereo Universal RP Graphics Tests from LegacyXR to XRSDK by cherry-picking the relevant commits from PR 267, which enabled XRSDK for these tests on master.
#267
My ABV is "virtual green" in that two pipelines failed due to infrastructure issues but passed upon being re-run. See below for error messages and links.
Testing status
Manual Tests:
Automated Tests:
My ABV is "virtual green" in that two pipelines failed due to infrastructure issues but passed upon being re-run. See below for error messages and links.
_ABV for SRP repository - fast-2020.1
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/backport_pr_267_dennisd/.yamato%252F_abv.yml%2523all_project_ci_fast-2020.1/2668935/job
VFX_LWRP on Win_DX11_playmode on version fast-2020.1
Execution log errors:
[00:52:24.938 INF] Connection reset by 172.28.214.101 port 22
[00:52:24.949 INF] fatal: early EOF
[00:52:24.953 INF] fatal: The remote end hung up unexpectedly
Success upon re-run:
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/backport_pr_267_dennisd/.yamato%252Fvfx_lwrp-win-dx11.yml%2523VFX_LWRP_Win_DX11_playmode_fast-2020.1/2670700/job/pipeline
Execution log errors:
Reason(s): FAILURE REASON: One or more non-test related errors or failures occurred.
Total tests: 21
Failed test count: 0
Successful tests count: 21
Success upon re-run:
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/backport_pr_267_dennisd/.yamato%252Fshadergraph-win-dx11.yml%2523ShaderGraph_Win_DX11_playmode_fast-2020.1/2670699/job/pipeline
Comments to reviewers
Approval from either of the two reviewers is sufficient. Unless you see something dire that I overlooked, whichever of you reviewers this first should probably go ahead and merge it.