Skip to content

Shadows for the cloud layer#1155

Closed
adrien-de-tocqueville wants to merge 4 commits into
HDRP/stagingfrom
HDRP/cloud-shadow
Closed

Shadows for the cloud layer#1155
adrien-de-tocqueville wants to merge 4 commits into
HDRP/stagingfrom
HDRP/cloud-shadow

Conversation

@adrien-de-tocqueville
Copy link
Copy Markdown
Contributor

@adrien-de-tocqueville adrien-de-tocqueville commented Jul 6, 2020

Purpose of this PR

This PR is adding shadow computed from the cloud layer.
I tried two method, I think the second one is better

First method: It tries to show the cloud shape on the ground but this is strange in some places because the skybox moves with the camera (like the sun is behind a cloud but you see no shadow)
cloud_shadows

Second method: Computes a global shadow factor for the whole scene
cloud_shadow


Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics


Comments to reviewers

There's a default cloud texture named DefaultCloudLayer included in the package.

@adrien-de-tocqueville adrien-de-tocqueville changed the base branch from master to HDRP/staging July 6, 2020 14:47
@adrien-de-tocqueville adrien-de-tocqueville deleted the HDRP/cloud-shadow branch July 29, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant