-
Notifications
You must be signed in to change notification settings - Fork 862
[Shadergraph] Updated Blackboard Resizer styles #1351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resizer section is really hard to grab now. It feels like there's only around 3 pixels high where the mouse can grab it (even though the element is supposedly 6px tall). I think 10px by 10px would work a lot better.
Edit: the problem seems to be when the mouse approaches from the bottom. There's a space where the mouse should be turning into a resizer icon but it doesn't until you get around 3 pixels into the ui element. If you changed it to 10 px high I think this would fix that problem.
Corrected changelog mistake.
This resolves the issue after the trunk PR lands, but doesn't do much without that landing. I messed up or wasn't aware of the PR process in ono so it was a bit delayed. |
As per request.
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New resizer handle is way easier to click now. Approving.
This change is in conjunction with this one in trunk https://github.cds.internal.unity3d.com/unity/unity/pull/1415, though pushing this now doesn't cause any problems.
I pulled hardcoded styling information for the 'resizer' that the blackboard uses and put them into the default styles so that they can be overridden accordingly. This is the package local override for those settings to prevent UI elements from fighting.
https://fogbugz.unity3d.com/f/cases/1253962/
https://fogbugz.unity3d.com/f/cases/1163697/
Manual testing-- the resize handle no longer blocks the scrollbars.
Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics