Refactor cloud layer [2021.2]#1481
Closed
adrien-de-tocqueville wants to merge 13 commits into
Closed
Conversation
|
It appears that you made a non-draft PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR change the cloud layer interface to add more settings, mainly option to have two layers of clouds, it also adds a basic lighting option and an option to have clouds cast shadows for the sun light.
The PR also add the possibility for volume components to have nested parameters
For example:
The PR is not ready yet because the default cloud map needs to be redone
Errors on Vulkan:
after check, this error also happens on staging but the test still work (it might need to be fixed though)
probably related to the shadow texture, but it is quite random
Testing status
Updated test scene 5010 to include new features
Comments to reviewers