Skip to content

Refactor cloud layer [2021.2]#1481

Closed
adrien-de-tocqueville wants to merge 13 commits into
HDRP/stagingfrom
HDRP/refactor-cloud-layer
Closed

Refactor cloud layer [2021.2]#1481
adrien-de-tocqueville wants to merge 13 commits into
HDRP/stagingfrom
HDRP/refactor-cloud-layer

Conversation

@adrien-de-tocqueville
Copy link
Copy Markdown
Contributor

@adrien-de-tocqueville adrien-de-tocqueville commented Aug 3, 2020

Purpose of this PR

This PR change the cloud layer interface to add more settings, mainly option to have two layers of clouds, it also adds a basic lighting option and an option to have clouds cast shadows for the sun light.

editor

The PR also add the possibility for volume components to have nested parameters
For example:

public class Component: VolumeComponent
{
    // This doesn't change
    public ClampedFloatParameter a = new ClampedFloatParameter(0.0f, 0.0f, 1.0f);

    // This is now possible
    [Serializable]
    public class NestedClass
    {
        public ClampedFloatParameter b = new ClampedFloatParameter (0.0f, 0.0f, 1.0f);
    }

    public NestedClass nested = new NestedClass();
}

The PR is not ready yet because the default cloud map needs to be redone
Errors on Vulkan:

  • on yamato "Compute dispatch: missing constant buffer"
    after check, this error also happens on staging but the test still work (it might need to be fixed though)
  • sometimes on local machine "Compute dispatch: missing texture ID"
    probably related to the shadow texture, but it is quite random

Testing status

  • Tested with all skies
  • Tested disabling sunlight
  • Putting a cubemap in the cloud map slot writes an error to the console (this happens on other components also, don't know if this is the right thing to do)
  • Tested texture baking
  • Tested with/without static sky

Updated test scene 5010 to include new features


Comments to reviewers

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 3, 2020

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@adrien-de-tocqueville adrien-de-tocqueville marked this pull request as draft August 3, 2020 10:31
@sebastienlagarde sebastienlagarde changed the title Refactor cloud layer Refactor cloud layer [2021.2] Sep 16, 2020
@adrien-de-tocqueville adrien-de-tocqueville deleted the HDRP/refactor-cloud-layer branch November 24, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant