Skip to content

Conversation

@theopnv
Copy link
Contributor

@theopnv theopnv commented Aug 18, 2020

Purpose of this PR

Fix #1622 when the dependencies version is the same.

Prior to this PR, executing this job with dependencies version unchanged made it fail. It was because we edited the file and started the git pipeline no matter what, even if the dependencies did not change.

From now on we edit/commit/push the files only if the dependencies actually changed.


Testing status

Manual Tests: What did you do?

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Ffix-templates-auto-bump/.yamato%252F_preview_publish.yml%2523auto-version

@theopnv theopnv requested review from a team and sophiaaar August 18, 2020 12:51
theopnv and others added 10 commits August 18, 2020 16:10
com.unity.render-pipelines.core: 10.1.0-preview.10
com.unity.render-pipelines.high-definition-config: 10.1.0-preview.10
com.unity.render-pipelines.high-definition: 10.1.0-preview.10
com.unity.render-pipelines.lightweight: 10.1.0-preview.4
com.unity.render-pipelines.universal: 10.1.0-preview.10
com.unity.shadergraph: 10.1.0-preview.10
com.unity.visualeffectgraph: 10.1.0-preview.10
com.unity.render-pipelines.core: 10.1.0-preview.10
com.unity.render-pipelines.high-definition-config: 10.1.0-preview.10
com.unity.render-pipelines.high-definition: 10.1.0-preview.10
com.unity.render-pipelines.lightweight: 10.1.0-preview.4
com.unity.render-pipelines.universal: 10.1.0-preview.10
com.unity.shadergraph: 10.1.0-preview.10
com.unity.visualeffectgraph: 10.1.0-preview.10
@theopnv theopnv removed request for a team and sophiaaar August 19, 2020 13:08
@theopnv theopnv closed this Aug 19, 2020
@theopnv
Copy link
Contributor Author

theopnv commented Aug 19, 2020

Closing this one as the commit history is messy, due to the testing I did.
Final changes have been moved to #1642.

@theopnv theopnv deleted the yamato/fix-templates-auto-bump branch August 24, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants