Skip to content

Conversation

@theopnv
Copy link
Contributor

@theopnv theopnv commented Sep 11, 2020

@theopnv theopnv changed the title Add template tests to ABV Add template tests to ABV [skip ci] Sep 11, 2020
@theopnv theopnv requested review from a team, kivistikliis and sophiaaar September 11, 2020 10:02
@sophiaaar
Copy link
Contributor

i have 2 questions:

  1. will this be stable enough to run in ABV (as opposed to only nightly)?
  2. could problems arise when the version bumps after each push to master?

@theopnv
Copy link
Contributor Author

theopnv commented Sep 15, 2020

  1. Let me add these to the nightly instead. In a few weeks we can reconsider. We can even leave them in the nightly, now that we can benefit from Evergreen and in an effort to reduce the load on ABV.
  2. I'm not sure to completely understand. Are you referring to validation problems like there https://docs.unity3d.com/Packages/com.unity.package-validation-suite@0.15/manual/lifecycle_validation_error.html? In that case we would have to fix the issue on a case-by-case basis. Or other kinds of problems?

@theopnv theopnv changed the title Add template tests to ABV [skip ci] Add template tests to Nightly [skip ci] Sep 15, 2020
@sophiaaar
Copy link
Contributor

  1. great 👍
  2. i think im just worried that things could get out of sync with the template, but im sure its fine, and having it nightly will mean that if something does happen, it won't block anyone

@theopnv theopnv marked this pull request as ready for review September 15, 2020 14:53
@theopnv theopnv changed the title Add template tests to Nightly [skip ci] Add template tests to Nightly Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants