AxF Fix missing alpha blend state properties and update stencil prop #2705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @slunity! |
sebastienlagarde
approved these changes
Nov 23, 2020
sebastienlagarde
changed the title
sebastienlagarde
added a commit
that referenced
this pull request
Nov 23, 2020
* Update 1900_AlphaTestSG.renderTexture (#2608) * update GBuffer description. * Added a warning when trying to bake with static lighting being in an invalid state. (#2597) * Added a warning when trying to bake with static lighting being in an invalid state. * Update changelog. * [HDRP] Fix runtime debug UI showing wrong entry (#2595) * Redraw debug before re-registring the debugs * changelog * Fixed multi-editing with new light intensity slider (#2600) * Fixed multi-editing with new light intensity slider * Only update floatValue when changed * Fixed useless editor repaint when using lod bias (#2601) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with density volume gizmo editing (#2603) * Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP][Compositor] Fix issues with image layers (#2606) * Empty image layers in the graphics compositor don't render black anymore * Improve camera management in compositor * Revert "Improve camera management in compositor" This reverts commit cc3971d. * Update changelog * For image layers that are first, still clear to black if no texture is attached Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed issue when decal projector material is none (#2615) * Fixed angle fading when rotating decal projector (#2618) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with gameview repaint in the graphics compositor (#2617) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove cyanish color shifting during sharpening in YCoCg in TAA (#2627) * Do sharpening in RGB space. * Fix alpha case * Oops * Ref update aside OSX * OSX refs * More refs * Missing refs. * Did I get the wrong ref? * Fixed the sampling of the normal buffer in the the forward transparent pass. (#2643) * Fixed the sampling of the normal buffer in the the forward transparent pass. * Update changelog * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass reorder issue (#2609) * Fix custom pass reorder issue * Fix bad comment * Refactor * Fix bloom prefiltering tooltip (#2715) * update reference screenshot for test 1900_AlphaTest_SG * Fix error when loading new scene (#2713) * Fix error when loading new scene * Update CHANGELOG.md * AxF Fix missing alpha blend state properties and update stencil prop (#2705) * AxF: Fix missing alpha blend state properties and update stencil properties. * Add changelog entry. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix custom pass normal and template (#2716) * Fix custom pass template not compiling * Fix custom pass normal buffer not bound * Updated changelog * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [HDRP][Compositor] Fix edge cases when cameras are missing or deleted (#2700) * Fix warning spam related to cameras in compositor * Fix null reference in AOVs * Fix null reference when disabling camera in the compositor * Reset target texture when disabling the compositor * Update changelog + fix warning when output camera is deleted * Fix issue when adding image layer without any cameras in the scene * Fix error when disabling layer with no camera Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update CHANGELOG.md Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Some alpha blending properties backing pass state were not carried over, this created peculiar bugs only visible for clients that tried to use the alpha for compositing. Updated also the stencil properties to reflect changes in HDRP.
Testing status
Describe what manual/automated tests were performed for this PR
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/axf-fix-blend-stencil-state/.yamato%252Fall-hdrp.yml%2523All_HDRP_trunk/4286852/job/pipeline
All green except Vulkan, unrelated.
Comments to reviewers
Notes for the reviewers you have assigned.