[8.x.x] Fixed URP bug causing HDR skyboxes to render as LDR on XR #2877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are not supporting 8.x.x packages anymore. You can upgrade to 10.x.x or master. If this issue is not fixed in master please open a PR to targetting master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixes bug introduced in f19a224, which resulted in HDR skyboxes (and more?) not rendering as such on XR. Caused by camera render texture descriptors not being assigned properly.
The change pretty much reintroduces a code block which was there prior to the mentioned commit.
Steps to reproduce the issue
Import XR, URP, add an HDR skybox. Run and watch it not be rendered as HDR.