Skip to content

[8.x.x] Fixed URP bug causing HDR skyboxes to render as LDR on XR #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[8.x.x] Fixed URP bug causing HDR skyboxes to render as LDR on XR #2877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f455466
Fixes issue where URP wouldnt render HDR skyboxes
einaros Dec 8, 2020
d90da36
Update changelog.md
einaros Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions com.unity.render-pipelines.universal/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this package will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [8.3.2] - XXXX-XX-XX

### Fixed
- Fixed an issue where HDR would never be enabled for camera render textures while in XR.

## [8.3.1] - 2020-07-23

### Fixed
Expand Down
11 changes: 7 additions & 4 deletions com.unity.render-pipelines.universal/Runtime/UniversalRenderPipelineCore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,14 @@ static RenderTextureDescriptor CreateRenderTextureDescriptor(Camera camera, floa
desc = new RenderTextureDescriptor(camera.pixelWidth, camera.pixelHeight);
desc.width = (int)((float)desc.width * renderScale);
desc.height = (int)((float)desc.height * renderScale);
}
else
{
desc = camera.targetTexture.descriptor;
}

if (camera.targetTexture == null)
{
GraphicsFormat hdrFormat;
if (!needsAlpha && RenderingUtils.SupportsGraphicsFormat(GraphicsFormat.B10G11R11_UFloatPack32, FormatUsage.Linear | FormatUsage.Render))
hdrFormat = GraphicsFormat.B10G11R11_UFloatPack32;
Expand All @@ -346,10 +353,6 @@ static RenderTextureDescriptor CreateRenderTextureDescriptor(Camera camera, floa
desc.msaaSamples = msaaSamples;
desc.sRGB = (QualitySettings.activeColorSpace == ColorSpace.Linear);
}
else
{
desc = camera.targetTexture.descriptor;
}

desc.enableRandomWrite = false;
desc.bindMS = false;
Expand Down