Skip to content

[7.x.x] Remove unnecessary command from yml #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2020
Merged

[7.x.x] Remove unnecessary command from yml #294

merged 1 commit into from
Apr 28, 2020

Conversation

sophiaaar
Copy link
Contributor

@sophiaaar sophiaaar commented Apr 28, 2020 •
edited
Loading

Purpose of this PR

  • Remove unnecessary npm install command, which fixes this error:
    [06:42:16.445 INF] [UPM-CI-UTILS] ERROR - Usage of Bintray registry https://api.bintray.com/npm/unity/unity-npm will become obsolete by May 2020. Please, change the npm url https://api.bintray.com/npm/unity/unity-npm in C:\build\output\Unity-Technologies\Graphics\.yamato\upm-ci-universal_stereo.yml for 'https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm'

Comments to reviewers

  • The broken URL has already been removed/replaced in other files. I assume these files got missed in the backport of [CI] Change npm registry [skip ci] #199 because the URL had already been removed in master
  • Cancelled ABV, so that's why it shows as failed

@sophiaaar sophiaaar requested a review from a team as a code owner April 28, 2020 09:14
@sophiaaar sophiaaar merged commit 0b6846c into 7.x.x/release Apr 28, 2020
@sophiaaar sophiaaar deleted the 7.x.x/update-registry-url branch April 28, 2020 09:20
PaulDemeulenaere added a commit that referenced this pull request Nov 19, 2021
@julienamsellem @PaulDemeulenaere
Fixed NRE when debug mode is active and changing opened VFX asset (#294)
8c5708d 
* Fixed NRE when debug mode is active and changing opened VFX asset

* Updated changelog

* Update changelog with public link

Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>

Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>
@PaulDemeulenaere PaulDemeulenaere mentioned this pull request Nov 25, 2021
Merged
julienamsellem added a commit that referenced this pull request Dec 2, 2021
@julienamsellem @PaulDemeulenaere
Fixed NRE when debug mode is active and changing opened VFX asset (#294)
20c3377 
* Fixed NRE when debug mode is active and changing opened VFX asset

* Updated changelog

* Update changelog with public link

Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>

Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>
# Conflicts:
#	com.unity.visualeffectgraph/CHANGELOG.md
julienamsellem added a commit that referenced this pull request Dec 10, 2021
@julienamsellem @PaulDemeulenaere
Fixed NRE when debug mode is active and changing opened VFX asset (#294…
0b604ad 
…) (#6462)

* Fixed NRE when debug mode is active and changing opened VFX asset

* Updated changelog

* Update changelog with public link

Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>

Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>
# Conflicts:
#	com.unity.visualeffectgraph/CHANGELOG.md
julienf-unity pushed a commit that referenced this pull request Jan 13, 2022
@julienamsellem @PaulDemeulenaere @julienf-unity
Fixed NRE when debug mode is active and changing opened VFX asset (#294)
d3df8ed 
* Fixed NRE when debug mode is active and changing opened VFX asset

* Updated changelog

* Update changelog with public link

Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>

Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stramit stramit stramit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

yamato

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sophiaaar @stramit