[VFX] Staging to master #6400

PaulDemeulenaere · 2021-11-25T17:39:30Z

Purpose of this PR

Allow systems with no attributes to run #300 @ludovic-theobald
Fixed NRE when debug mode is active and changing opened VFX asset #294 @julienamsellem
Remove unwanted switch to runtime mode when saving #298 @julienf-unity
Add missing gles3 platform to list of #pragma only_renderers #295 @gabrieldelacruz

Testing status

Yamato 🟢 (but instable)

Comments to reviewers

N/A

…t to 10.x.x)

* Fix debug view material TODO : Add GraphicTest * Fix tab/space mix * Add HDRP debug scene * *Add reference image for HDRD_Debug(Property) * *Update changelog.md

…158)

* do not Create VFXGraph in import callbacks * error when graph missing. Better test code for asset creation

…n the asset inside the editor. (#118) * Added OnOpenAssetAttributeMode.Validate * added UNITY_2021_1 * remove the shaders has they are not edited in the editor. * Fix macro

# Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md

* Select node on create * Fix for right click in block and add doesn't deselect clicked block * fix for subgraph not being selected on drag and drop * Select converted node/block after convert subgraph * Fix for selection undo separate in some cases. Fixed flow anchor drag context selection. * Fix for undo of add subgraph operator

# Conflicts: # com.unity.render-pipelines.high-definition/Editor/Upgraders/UpgradeStandardShaderMaterials.cs # com.unity.render-pipelines.high-definition/Runtime/Lighting/Reflection/HDProbeSystem.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/RenderPass/AOV/AOVRequestData.cs # com.unity.render-pipelines.universal/Editor/2D/Renderer2DUpgrader.cs # com.unity.render-pipelines.universal/Editor/2D/ShapeEditor/EditorTool/ScriptablePathInspector.cs # com.unity.render-pipelines.universal/Editor/2D/ShapeEditor/GUIFramework/Control.cs # com.unity.render-pipelines.universal/Editor/2D/ShapeEditor/GUIFramework/GUIAction.cs # com.unity.render-pipelines.universal/Editor/2D/ShapeEditor/View/Drawer.cs # com.unity.render-pipelines.universal/Editor/LightExplorer.cs # com.unity.render-pipelines.universal/Editor/ShaderGraph/AssetCallbacks/CreateSpriteLitShaderGraph.cs # com.unity.render-pipelines.universal/Editor/ShaderGraph/AssetCallbacks/CreateSpriteUnlitShaderGraph.cs # com.unity.render-pipelines.universal/Editor/ShaderGraph/AssetCallbacks/CreateUnlitShaderGraph.cs # com.unity.render-pipelines.universal/Runtime/External/LibTessDotNet/Tess.cs # com.unity.shadergraph/Editor/AssetCallbacks/CreateVFXShaderGraph.cs # com.unity.shadergraph/Editor/Data/Graphs/ColorShaderProperty.cs # com.unity.shadergraph/Editor/Data/Nodes/LegacyUnknownTypeNode.cs # com.unity.shadergraph/Editor/Data/Nodes/NodeClassCache.cs

… "New" when no asset is set. (#173) * Base Commit * Documentation * Updated Changelog * Fixed Typo Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Added excludeFromTAA setting to VFX outputs Added excludeFromTAA setting to VFX outputs. Currently it is only supported in HDRP suboutputs. Required adding ${VFXStencilForward} variable to forward pass templates * Update VFXHDRPSubOutput.cs suport exclude from TAA in transparent only * Added documentation to exclude from TAA property * Graphic test Added graphic test: 32_ExcludeFromTAA * Update graphic test background for better contrast * Update CHANGELOG.md Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>

@tristan

* Allow Set Spawn Count & Set Spawn Time TODO : List Spawn count in available variant * Fix reference lost in m_SerializableType No idea of implication of this :-/ * Squashed commit of the following: (retrieve fix from @tristan) commit c24981d7dad15100eb40a92a6a9370e9ba800acd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 17:27:57 2020 +0200 Update message from @vlad suggestion Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#issuecomment-30757 commit a87ba18 Merge: 13b501e 296ffd3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 09:25:02 2020 +0200 Merge branch 'vfx/staging' into vfx/fix/error-at-creation # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 13b501e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Oct 9 09:24:27 2020 +0200 *Add warning for CollisionDepthBuffer Update & Fix Changelog.md commit 4bfb1e7 Author: Tristan Genevet <tristan@unity3d.com> Date: Thu Oct 8 18:10:42 2020 +0200 Fix for displaying error from the creation of a node. * Add error feedback on failing custom spawner reference * Revert "Allow Set Spawn Count & Set Spawn Time" This reverts commit 0a6c75c. # Conflicts: # com.unity.visualeffectgraph/Editor/Expressions/VFXAttributeExpression.cs * Remove unexpected change * *Revert change in changelog * *WIP* add ResolveCustomCallbackInstance Some refactor mark as "TODOPAUL" * Clean implementation : customBehavior & comment * *Add test to cover sanitize before modify references * Change namespace for builtin custom spawner & sanitize * Extend test to verify connexion * *Update changelog.md * Add specific error if customBehavior returns null * Fix corner case when ScriptableObject reference has been lost * Work but not idea with copy/past + potential leak * Better implementation : use directly "MonoScript" * Fix spawnerTest * Rename "Can't found" => "Can't find"

…pacity (#174) Issue introduced with https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136 And more precisely https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136/commits/27c041da92ec89407ae775fe4c4f24681f156cb8

* Add test * Add test to cover behavior from case 1271839

* Trick ExcludeFromPreset Since this attribute is declared with "Inherited = false", we can't use it directly on VFXObject. Extend the VFXInfo is valid to filter out preset. * Fix missing ExcludeFromPreset for subgraph * *Update changelog

* Base Commit * Updated Documentation with explicit limitations. * Fixed incorrect Merge * Add regression Test * Removed Test as It can't handle Exceptions thrown in Custom Importers * Fixed value divider Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Update gradient test * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Initial commit * Overflow handling options for the user * Addressing mode for overflow to the choice of the user * Foldable to Constant value * Update 09_PointCache.vfx * Added reference images * Remove float-to-integer conversion * Put the choice of the output type in the Inspector only * Simplify output type handling * Sample Point cache != Attribute map => two operators * Update Branch (error .yamato/docs/editor_pinning.png) * Update SamplePointCache.cs * Update 09_PointCache.vfx * Output type set in a cogwheel * Update 09_PointCache.vfx * Revert "Update Branch (error .yamato/docs/editor_pinning.png)" This reverts commit 02f6b6c993c2382bb10669edd16f7d06876a0cbc. * Restore vfx asset * Revert back to using generics for type handling * Update SampleAttributeMap.cs * Reformating + changelog * Update 09_PointCache.vfx * Update SamplePointCache.cs * Refactor of AttributeFromMap using VFXExpressionSampleAttributeMap * Merge branch 'vfx/staging' into vfx/feature/sample-point-cache * Revert "Merge branch 'vfx/staging' into vfx/feature/sample-point-cache" This reverts commit b4a03e182a3e106c2fabc262777615f9c3b94a7e.

* Update Pass.template * Update CHANGELOG.md

…fx-graphics into vfx/staging

* Enable LPPV in HDRP test project * Fix LPPV for gbuffer pass * Add graphics test * Update changelog

+ Update VFXManager in test project

perl $HOME/unity-meta/Tools/Format/format.pl --nobackups --hgroot $(pwd) .

# Conflicts: # TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/VFXTests/GraphicsTests/31_CameraBuffer.vfx

Needed after merge of #5125

* Fixed NRE when debug mode is active and changing opened VFX asset * Updated changelog * Update changelog with public link Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>

* Fix bug with a static * Update changelog

* Add HasAttributeBuffer flag + increment compiledVersion * changelog

# Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md

Also double check there isn't any change in VFX asset

PaulDemeulenaere · 2021-11-29T08:43:54Z

There is an issue with Win_DX11_editmode_mono_Linear

I'm sometime getting the issue locally, not sure about the repro

All in all, it isn't specific to vfx/stating, it also occurs on master:

github-actions · 2021-11-29T13:25:40Z

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

VFX
/jobDefinition/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

* [VFX] Staging to master (#6400) * Early backport of #6438 It fixes test in edit mode

PaulDemeulenaere and others added 30 commits November 12, 2020 10:40

Restore disabled 26_NonUnifomScale due to a wrong merge (need backpor…

f181b2d

…t to 10.x.x)

[HDRP] Fix debug view material (albedo/normal/...) (#163)

0c4cf10

* Fix debug view material TODO : Add GraphicTest * Fix tab/space mix * Add HDRP debug scene * *Add reference image for HDRD_Debug(Property) * *Update changelog.md

Force ui update when shader might be reimported in StaticMeshOutput (#…

981e074

…158)

Don't create VFXGraph during import callbacks (#148)

1443b7d

* do not Create VFXGraph in import callbacks * error when graph missing. Better test code for asset creation

Add the necessary openasset callback for the system to know if we ope…

47ce7f8

…n the asset inside the editor. (#118) * Added OnOpenAssetAttributeMode.Validate * added UNITY_2021_1 * remove the shaders has they are not edited in the editor. * Fix macro

Merge branch 'master' into vfx/staging

960eea5

# Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md

Merge remote-tracking branch 'graphics/master' into vfx/staging

0a7f877

“Refactor”

1f63413

"Refactor" bis (some file has been missed)

b6d84e9

Dont flag dirty in vfxgraph is the model modified is a copy (#165)

b514cc6

Workflow improvement : Change VisualEffect inspector "Edit" button to…

1f96809

… "New" when no asset is set. (#173) * Base Commit * Documentation * Updated Changelog * Fixed Typo Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

Missing Reference image for test 32_ExcludeFromTAA

5015bd6

Add test to cover case exposed by 1258022 (#54)

cc36c16

[Test] Add test to cover "Thread Group Size" error (#104)

cf3b4ae

* Add test * Add test to cover behavior from case 1271839

Fix Preset (with exclusion) (#177)

ff94af5

* Trick ExcludeFromPreset Since this attribute is declared with "Inherited = false", we can't use it directly on VFXObject. Extend the VFXInfo is valid to filter out preset. * Fix missing ExcludeFromPreset for subgraph * *Update changelog

Update gradient test (#151)

a515f2f

* Update gradient test * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com>

Fix point cache vfx + update HDRP vfx

071ce22

Update URP assets

a6ee6de

Fix changelog

8b44f3b

Merge branch 'master' into vfx/staging

7649fe1

Fix Case 1223747 - NaN caused by normal bending (#181)

83ad751

* Update Pass.template * Update CHANGELOG.md

Merge branch 'vfx/staging' of github.cds.internal.unity3d.com:unity/v…

ebcf59f

…fx-graphics into vfx/staging

1293608 - Fix LPPV not working in deferred (#180)

8f3b4f9

* Enable LPPV in HDRP test project * Fix LPPV for gbuffer pass * Add graphics test * Update changelog

PaulDemeulenaere and others added 15 commits October 29, 2021 12:25

*Update all serialized vfx

a5ca47b

+ Update VFXManager in test project

*Re-Apply Formatting

8a8f15c

perl $HOME/unity-meta/Tools/Format/format.pl --nobackups --hgroot $(pwd) .

Merge branch 'master' into vfx/staging

a952bd6

Merge branch 'master' into vfx/staging

f1bd5b3

# Conflicts: # TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/VFXTests/GraphicsTests/31_CameraBuffer.vfx

Add missing meta

73bcb5e

*Update All VFX

8065aea

Needed after merge of #5125

Merge remote-tracking branch 'graphics/master' into vfx/staging

12493ff

Merge remote-tracking branch 'graphics/master' into vfx/staging

c7b6ff5

Add missing gles3 platform to list of #pragma only_renderers (#295)

26c5f93

Merge branch 'master' into vfx/staging

9e0d474

Fix 1371089 - Remove unwanted switch to runtime mode when saving (#298)

21fca21

* Fix bug with a static * Update changelog

[Fix][Case 1341789] Allow systems with no attributes to run (#300)

5b10595

* Add HasAttributeBuffer flag + increment compiledVersion * changelog

Merge branch 'master' into vfx/staging

8277cae

# Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md

Fix changelog.md ordering

5438096

github-actions bot added the vfx label Nov 25, 2021

PaulDemeulenaere requested a review from julienf-unity November 25, 2021 17:44

Unity-Technologies deleted a comment from github-actions bot Nov 25, 2021

*Update VFXManager.asset

e0fc703

Also double check there isn't any change in VFX asset

Unity-Technologies deleted a comment from github-actions bot Nov 25, 2021

PaulDemeulenaere marked this pull request as ready for review November 29, 2021 08:44

Merge branch 'master' into vfx/staging

98b05fe

julienf-unity approved these changes Nov 29, 2021

View reviewed changes

julienf-unity merged commit ddf69f7 into master Nov 29, 2021

julienf-unity deleted the vfx/staging branch November 29, 2021 13:25

PaulDemeulenaere added a commit that referenced this pull request Nov 30, 2021

[VFX] Staging to master (#6400)

5538256

PaulDemeulenaere mentioned this pull request Nov 30, 2021

[VFX] Staging to 2022.1 #6431

Merged

PaulDemeulenaere added a commit that referenced this pull request Dec 16, 2021

[VFX] Staging to 2022.1 (#6431)

2bde742

* [VFX] Staging to master (#6400) * Early backport of #6438 It fixes test in edit mode

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[VFX] Staging to master #6400

[VFX] Staging to master #6400

Uh oh!

PaulDemeulenaere commented Nov 25, 2021 •

edited

Loading

Uh oh!

PaulDemeulenaere commented Nov 29, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Nov 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[VFX] Staging to master #6400

[VFX] Staging to master #6400

Uh oh!

Conversation

PaulDemeulenaere commented Nov 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Testing status

Comments to reviewers

Uh oh!

PaulDemeulenaere commented Nov 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

PaulDemeulenaere commented Nov 25, 2021 •

edited

Loading

PaulDemeulenaere commented Nov 29, 2021 •

edited

Loading