Skip to content

Move APV to Core and remove shader config dependency + auto load in player without external script#3000

Merged
sebastienlagarde merged 23 commits into
masterfrom
HDRP/move-APV-to-core
Jan 11, 2021
Merged

Move APV to Core and remove shader config dependency + auto load in player without external script#3000
sebastienlagarde merged 23 commits into
masterfrom
HDRP/move-APV-to-core

Conversation

@FrancescoC-unity
Copy link
Copy Markdown
Contributor

This PR does a couple of things:

  • Remove the dependency on shader config. Substituted it with a multi_compile in shader.
  • Added a multi compile for L1 and L2, at the moment L2 doesn't do anything different, it is just a setup for when we'll implement.
  • Move practically all files to core.
  • Added warning in editors if anything but HDRP is used.
  • Changed visibility for several things.
  • Added some documentation for stuff that is public.
  • Made it so the asset gets loaded directly from the component that is used in editor. Previously the system needed an external per-project script, now is not needed.
  • Deleted some code that was dead.

@FrancescoC-unity FrancescoC-unity self-assigned this Jan 6, 2021
@github-actions github-actions Bot added the SRP label Jan 6, 2021
@sebastienlagarde sebastienlagarde marked this pull request as ready for review January 8, 2021 11:24
Copy link
Copy Markdown
Contributor

@thefranke thefranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

@sebastienlagarde sebastienlagarde merged commit f4c891d into master Jan 11, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/move-APV-to-core branch January 11, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants