The RTAO's history is now discarded if the occlusion caster was moving (case 1303418). #3343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anisunity does it need to be backported? |
sebastienlagarde
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
I have the same type of remarks than the RT shadows threshold thing.
At very low velocity, nothing has changed. ✔️
At high velocity, history is discarded and we don't get severe ghosting with RTAO. ✔️
At low velocity however, this is where you hit the velocity threshold and if you are right around it, it will flicker back and forth between discarding history and not and each time you can see a "jump".
I'm not sure there's a real solution here apart from having another parameter like in the TAA that would be a speed rejection threshold of some sort.
Just wanted to point that it can be a trade off in some specific situation.
Comparison at high velocities
BEFORE THE PR
AFTER THE PR
BEFORE THE PR
AFTER THE PR
remi-chapelain
approved these changes
Feb 3, 2021
…g (case 1303418).
anisunity
force-pushed
the
HDRP/fix-1303418
branch
from
89eece8 to
18bd180
Compare
sebastienlagarde
added
backported-2021.1
needs-backport-2021.1
and removed
needs-backport-2021.1
backported-2021.1
labels
sebastienlagarde
pushed a commit
that referenced
this pull request
Mar 3, 2021
…ng (case 1303418). #3343
sebastienlagarde
added a commit
that referenced
this pull request
Mar 3, 2021
* Fix a flickering issue related to moving shadow receivers (case 1302392) and a refactoring to avoid computing the same value for every effect. #3039 * The RTAO's history is now discarded if the occlusion caster was moving (case 1303418). #3343 * Update CHANGELOG.md * Add new API to CachedShadowManager and fix WouldFitInAtlas #3387 * Added master stack documentation for HDRP (#3388) * Added landing page and context/blocks overview page * Added vertex context page and snippets * Added the fragment context page and supporting snippets * Added the decal master stack and the contexts intro * Updated toc * Added vertex context doc * Update TableOfContents.md * Added unlit doc * Added lit master stack doc * Added eye master stack doc * Added fabric master stack * added hair master stack * Added stacklit master stack * Added snippets to support shader stack work * Fixed some formatting bugs * Removed old links * Updated links * formatting Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Sub-shadow rendering with cached shadows + Fix PCSS filtering issues on first frame or cached shadows #3396 * Reset ambient probe upon switching to very different skies bis #3423 * HDRP Graphic Test Fixes for Metal (#3408) * Fixed the metal pipeline creation error message and updated several gfx test images. * Rearranged LightData definition to workaround area lights not rendering issue on Intel GPUs on Catalina * Updated 2501 reference image for Metal with the area light fix * Updated 1550 and 2010 on Metal as previous were incorrect due to area light issue Co-authored-by: Jeannette Yu <jeannette.yu@unity3d.com> * Custom Pass error message fix (#3424) Typo in DrawRenderersCustomPass error message. Fixed a few other typos in this section too :D * Add Unity version to what's new 11 (#3432) * Update whats-new-11.md * Updated the table of contents * Shader abstraction cleanup #3443 * Some leftover caused by master merge (#3456) * Fix multiple any hit occuring on transparent objects (case 1294927). #3471 * Colored Shadows update (#3486) * Colored Shadows update Included new information in the Color Shadow property description to tell the user that the Material's Refraction Model has to be set to Thin, Box or Sphere for it to work. * Fixed typo Removed the "the" :D * Revert "Fix multiple any hit occuring on transparent objects (case 1294927). #3471" This reverts commit 0587177. * Update 1219_Lit_Light_on_Tesselation.png Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Brandon Fogerty <34072588+brandon-unity3d@users.noreply.github.com> Co-authored-by: Jeannette Yu <jeannette.yu@unity3d.com> Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com> Co-authored-by: robinb-u3d <robinb-u3d@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves partially the issue (the rest of the issue is solved by this PR) #3039 This discards the history of the intersected occluder is moving.
https://fogbugz.unity3d.com/f/cases/resolve/1303418/
Testing status
Tried the repro shared by the QA, doesn't repro anymore.
DXR tests are green locally.