Mobile/fix depth of field on adreno3 xx #4246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelinastaniulyte
requested review from
evelinastaniulyte
and removed request for
a team
simon-engelbrecht-soerensen
approved these changes
Apr 22, 2021
phi-lira
approved these changes
Apr 22, 2021
Comment on lines
+369
to
+371
| // Adreno 3xx SystemInfo.graphicsShaderLevel is 35, but instancing support is disabled due to buggy drivers. | ||
| // DOF shader uses #pragma target 3.5 which adds requirement for instancing support, thus marking the shader unsupported on those devices. | ||
| var dofMaterial = m_DepthOfField.mode.value == DepthOfFieldMode.Gaussian ? m_Materials.gaussianDepthOfField : m_Materials.bokehDepthOfField; |
There was a problem hiding this comment.
I dont' understand how the material returns null for Adreno 3xx here.
There was a problem hiding this comment.
If the shader is not supported, it returns null. That's a result of an older identical issue fix 9157ee7
evelinastaniulyte
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
The bug: https://fogbugz.unity3d.com/f/cases/1327076/ is verified as fixed. Depth of field in not initialised on Adreno 3xx devices.
Tested Adreno 3xx devices:
- VLNQA00104, Lge Nexus 5 (Nexus 5), Android 6.0.1, CPU: Snapdragon 800 MSM8974, GPU: Adreno (TM) 330
- VLNQA00111, Samsung Galaxy J5(2016) (SM-J510FN), Android 7.1.1, CPU: Snapdragon 410 MSM8916, GPU: Adreno (TM) 306
Also checked some other devices additionally. The Depth of Field is initialised as expected:
- VLNQA00340, Samsung Galaxy Note20 Ultra 5G (SM-N986B), Android 10, CPU: Exynos 990, GPU: Mali-G77
- VLNQA00280, Samsung Galaxy S10+ USA, CPU: Snapdragon 855 SM8150, GPU: Adreno 650, Android: 9
- VLNQA00287, Motorola moto g(7) power (moto g(7) power), Android 9, CPU: Snapdragon 625 MSM8953, GPU: Adreno (TM) 506
phi-lira
added
backported-10.x
and removed
needs-backport-7.x
needs-backport-10.x
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix case: https://fogbugz.unity3d.com/f/cases/1327076/
The depth of field shader has
pragma target 3.5. Devices with Adreno 3XX gpus report SystemInfo.graphicsShaderLevel is 35, but due to buggy drivers we have disabled instancing support on them. That causes the depth of field check for SystemInfo.graphicsShaderLevel to pass, but loading the shader fails due to lack of instancing support.Testing status
Manual testing on Nexus5/Adreno330
Comments to reviewers
Notes for the reviewers you have assigned.