[URP][Backport] fix depth of field on adreno3xx #6358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
phi-lira
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4246
Purpose of this PR
Fix case: https://fogbugz.unity3d.com/f/cases/1327076/
The depth of field shader has pragma target 3.5. Devices with Adreno 3XX gpus report SystemInfo.graphicsShaderLevel is 35, but due to buggy drivers we have disabled instancing support on them. That causes the depth of field check for SystemInfo.graphicsShaderLevel to pass, but loading the shader fails due to lack of instancing support.
Testing status
Manual testing on Nexus5/Adreno330
Comments to reviewers
Notes for the reviewers you have assigned.