Add coverage for path tracer alpha channel support #4393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iM0ve
approved these changes
Apr 30, 2021
sebastienlagarde
approved these changes
Apr 30, 2021
sebastienlagarde
added
backported-10.x
backported-2021.1
and removed
needs-backport-10.x
needs-backport-2021.1
labels
sebastienlagarde
pushed a commit
that referenced
this pull request
May 2, 2021
* add-pt-alpha-automated-test * Tidy up 5001 scene
sebastienlagarde
added a commit
that referenced
this pull request
May 5, 2021
* [HDRP][DXR] Add coverage for lighting full screen debug mode in DXR Tests Projects (#4391) * 5 new lighting debug mode scene * RTAO + SSShadows * build settings * Light Cluster scene * Contact shadows correct captures using BackBuffer * ContactShadow scene * forgot meta files * Add coverage for path tracer alpha channel support (#4393) * add-pt-alpha-automated-test * Tidy up 5001 scene * Disable DXR XR test (#4403) * Add support for lighting full screen debug mode for HDRP tests #4367 * Fix automated tests * upgrade path tracing alpha test * 5001 updated unreadable image * disable DXR XR 2005 Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
After a discussion with a user about this feature, a new test to avoid a possible future regression.
The test have two part, the first part, the camera render a path traced scene to a render texture with alpha (what is happening in the background)
Then this texture is used as input for the base color of on an unlit alpha clipped material used on a plane (foreground).
A checker is behind that planed to make the alpha-clipped front planed more obvious.
Needed to add a new HDRP asset to support R16G16B16A16 color buffer format.
Also, I've tidy up some other pathtracing scene for clarity. (Removed duplicate dir light for stability of test)
Testing status
Comments to reviewers
¯\(ツ)/¯