Skip to content

[ShaderGraph][2020.3][Backport] Fix 1365187 - correct direction transform from view to world space #5645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: ShaderGraph BoneIndex & BoneWeight Nodes
merged 2 commits into from
Sep 14, 2021
Merged

[ShaderGraph][2020.3][Backport] Fix 1365187 - correct direction transform from view to world space #5645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cc3763
Fix for 1365187 - correct direction transform from view to world space
jessebarker Sep 13, 2021
05ca6ee
Use "Unreleased" version tag in changelog
jessebarker Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions com.unity.shadergraph/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ All notable changes to this package are documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased] - 2021-09-13

### Added

### Fixed
- Fixed an incorrect direction transform from view to world space [1365187]

## [10.7.0] - 2021-07-02

### Added
Expand Down
4 changes: 3 additions & 1 deletion com.unity.shadergraph/Editor/Data/Nodes/Math/Vector/TransformNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,9 @@ public void GenerateNodeCode(ShaderStringBuilder sb, GenerationMode generationMo
{
if (conversion.to == CoordinateSpace.World)
{
transformString = string.Format("mul(UNITY_MATRIX_I_V, $precision4({0}, 1)).xyz", inputValue);
transformString = string.Format(conversionType == ConversionType.Direction ?
"mul(UNITY_MATRIX_I_V, $precision4({0}, 0)).xyz" :
"mul(UNITY_MATRIX_I_V, $precision4({0}, 1)).xyz", inputValue);
}
else if (conversion.to == CoordinateSpace.Object)
{
Expand Down