-
Notifications
You must be signed in to change notification settings - Fork 857
[HDRP] Adding a transparency setup samples #5707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
pcxrna5Uyx.mp4Yes looks like TMP fonts and shader got dropped. Also weird that only one mobile shader is packaged with this. Could be a bug with TMP not playing nicely with imported packages, will try to repro 👍 |
Hello I have too warnings about font not being found, making text not appear. It's great that you are doing this thank you. Indeed the sphere refraction model isn't looking too good, I noticed that there is some discrepancies between the behavior of sphere and box model with their behavior around thickness, this is stuff I hope we will tackle with transparency improvements work. As I said before to you I will gladly contribute to this transparency sample by giving models and/or shader. |
Quick update:
|
Closing the PR and linking the new one as this will probably be added to the material sample here. |
Purpose of this PR
The idea behind theses transparency setup samples is to share to the users the knowledge in that document.
In HDRP, different transparent setups are needed depending on which pipeline we use: Raster, Path Traced or Raster and Ray Tracing. Each of theses setup are not trivial nor intuitive to users.
For now, this sample only includes the scenes about shadows. Each part contains 3 scenes, one raster, one path traced, one mixing raster and ray tracing with details and instructions on the tiles.
It would be interesting to add some of theses infos (what's on the tiles) to the docs too and a link how to get the samples.
What will be added in later PRs
Informations and examples about:
WIP

Testing status
Comments to reviewers
Added @Vic-Cooper to have feedback on documentation and text that is inside the scene. Also I would like to know if you think it's interesting to include some of those bit in the documentation itself for redundancy.
For simplicity purpose, here's a gdoc with all the text.