-
Notifications
You must be signed in to change notification settings - Fork 856
[HDRP] Adding transparency setup scenes to material sample #6047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HDRP] Adding transparency setup scenes to material sample #6047
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
I asked my lead @IritArkinUnity about this, and in-context text doesn't fall under our docs remit. As such, you can publish this PR without my approval. If there's new information in this scene that isn't in the docs, please create a ticket for this task and we can scope the docs additions into a future sprint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the samples and listed the issues in the doc
Fixed most of the issue on the feedback document. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My found issues were addressed. Maybe still worth having a pass on the wording/text
Had a last discussion with @iM0ve and re-organized the scenes to highlights more the setup differences between them. b8fca283f153d37c1a4e2cc92706811f.mp4Ready to merge ✔️ |
Purpose of this PR
Following this (now closed) PR, it has been decided that it was better to include this in the material sample to avoid making the HDRP package bigger by sharing some of the materials / textures.
Moreover, given we want to reduce the size of the Editor, the size of the material sample have been drastically reduced.
What has been done mostly is converting the TGA to TIFF and reducing the size of unnecessary larger texture (2048 and 1024px).
It's still possible to go lower (still some large textures) but at the cost of losing some quality when getting close to the materials.
Testing status
Comments to reviewers
Added @Vic-Cooper to have feedback on documentation and text that is inside the scene. Also I would like to know if you think it's interesting to include some of those bit in the documentation itself for redundancy.
For simplicity purpose, here's a gdoc with all the text.