Skip to content

Fix draft reminder #5653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2021
Merged

Fix draft reminder #5653

merged 1 commit into from
Sep 14, 2021

Conversation

theopnv
Copy link
Contributor

@theopnv theopnv commented Sep 14, 2021

Purpose of this PR

The github action is not working anymore (credits go to Jesse for noticing it 🤘).
This is due to thollander/actions-comment-pull-request#25.
This PR fixes it by explicitly pinning the current version, that satisfies us. Not using @main future proofs us against potential regressions.

Testing status

Opened the PR in non draft mode, saw that the action works.

@theopnv theopnv requested a review from a team as a code owner September 14, 2021 14:35
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@theopnv theopnv merged commit 20f96b8 into master Sep 14, 2021
@theopnv theopnv deleted the github/fix-draft-reminder branch September 14, 2021 15:21
theopnv pushed a commit that referenced this pull request Sep 21, 2021
@theo-at-unity
Backport #5653
444f8e8
@theopnv theopnv mentioned this pull request Sep 21, 2021
Merged
theopnv pushed a commit that referenced this pull request Sep 21, 2021
@theo-at-unity
Backport #5653
c5909ee
@theopnv theopnv mentioned this pull request Sep 21, 2021
Merged
theopnv pushed a commit that referenced this pull request Sep 21, 2021
@theo-at-unity
Backport #5653
9bc1480
@theopnv theopnv mentioned this pull request Sep 21, 2021
Merged
theopnv pushed a commit that referenced this pull request Sep 21, 2021
@theo-at-unity
Backport #5653
765ef33
@theopnv theopnv mentioned this pull request Sep 21, 2021
Merged
theopnv pushed a commit that referenced this pull request Sep 21, 2021
[7.x.x] SDET backports (#5738)
646726d 
* Backport #5072

* Update README

* Backport #5653

* Backport #5627

* Backport #5721
theopnv pushed a commit that referenced this pull request Sep 21, 2021
[10xx] SDET backports (#5739)
aa1e1ed 
* Backport #5072

* Update README

* Backport #5653

* Backport #5627

* Update ppv2 publish filename
theopnv pushed a commit that referenced this pull request Sep 21, 2021
[2021.1] SDET Backports (#5740)
4c82363 
* Backport #5072

* Update README

* Backport #5653

* Backport #5627

* Change ppv2 filename
theopnv pushed a commit that referenced this pull request Sep 21, 2021
[2021.2] SDET Backports (#5741)
345951b 
* Backport #5653

* Backport #5721

* Backport #5753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kivistikliis kivistikliis kivistikliis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-7.x backported-10.x backported-2021.1 backported-2021.2 sdet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theopnv @kivistikliis @theo-at-unity